-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add local storage provider option and test for expired sesson signature #672
Open
joshLong145
wants to merge
7
commits into
master
Choose a base branch
from
test/add-local-storage-shim-session-sig-cache
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+95
−3
Open
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
f7a3152
add local storage provider optiion and test for expired sesson signature
5352175
chore: fmt
f715594
ref: remove import
74bdbbe
ci: remove local storage in ci
1d05b67
Merge branch 'master' into test/add-local-storage-shim-session-sig-cache
bc596bb
Merge branch 'master' into test/add-local-storage-shim-session-sig-cache
8bcdd72
Merge branch 'master' into test/add-local-storage-shim-session-sig-cache
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
64 changes: 64 additions & 0 deletions
64
local-tests/tests/testPkpSessionSigsIsValidAfterEllapsedTime.ts
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,64 @@ | ||
import { LIT_ENDPOINT_VERSION } from '@lit-protocol/constants'; | ||
import { log, validateSessionSigs } from '@lit-protocol/misc'; | ||
import { LIT_TESTNET } from 'local-tests/setup/tinny-config'; | ||
import { getPkpSessionSigs } from 'local-tests/setup/session-sigs/get-pkp-session-sigs'; | ||
import { TinnyEnvironment } from 'local-tests/setup/tinny-environment'; | ||
import { | ||
LitAbility, | ||
LitActionResource, | ||
LitPKPResource, | ||
} from '@lit-protocol/auth-helpers'; | ||
|
||
/** | ||
* Test Commands: | ||
* ✅ NETWORK=cayenne yarn test:local --filter=testUsePkpSessionSigsToPkpSign | ||
* ✅ NETWORK=manzano yarn test:local --filter=testUsePkpSessionSigsToPkpSign | ||
* ✅ NETWORK=localchain yarn test:local --filter=testUsePkpSessionSigsToPkpSign | ||
*/ | ||
export const testPkpSessionSigsIsValidAfterEllapsedTime = async ( | ||
devEnv: TinnyEnvironment | ||
) => { | ||
const alice = await devEnv.createRandomPerson(); | ||
|
||
let pkpSessionSigs = await getPkpSessionSigs( | ||
devEnv, | ||
alice, | ||
[ | ||
{ | ||
resource: new LitPKPResource('*'), | ||
ability: LitAbility.PKPSigning, | ||
}, | ||
{ | ||
resource: new LitActionResource('*'), | ||
ability: LitAbility.LitActionExecution, | ||
}, | ||
], | ||
new Date(Date.now() + 1000).toISOString() | ||
); | ||
await new Promise((res, rej) => { | ||
setTimeout(res, 2000); | ||
}); | ||
|
||
let res = validateSessionSigs(pkpSessionSigs); | ||
|
||
if (res.isValid) { | ||
throw new Error( | ||
'Session signature validation should fail with expiration ellapsed' | ||
); | ||
} | ||
console.log(res); | ||
try { | ||
const res = await devEnv.litNodeClient.pkpSign({ | ||
toSign: alice.loveLetter, | ||
pubKey: alice.authMethodOwnedPkp.publicKey, | ||
sessionSigs: pkpSessionSigs, | ||
}); | ||
} catch (e) { | ||
console.log( | ||
'✅ Session validation failed as expected: error is ', | ||
e.message | ||
); | ||
} | ||
|
||
devEnv.releasePrivateKeyFromUser(alice); | ||
}; |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The word
ellapsed
is misspelled in the error message. Consider changing it toelapsed
to maintain consistency with the function name and improve readability. This small correction will enhance the overall quality and professionalism of the code.Spotted by Graphite Reviewer
Is this helpful? React 👍 or 👎 to let us know.