Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tupek/cutback bcs when solve fails #1291

Open
wants to merge 22 commits into
base: develop
Choose a base branch
from

Conversation

tupek2
Copy link
Collaborator

@tupek2 tupek2 commented Dec 11, 2024

No description provided.

@tupek2 tupek2 added the WIP Work in progress label Dec 11, 2024
@tupek2
Copy link
Collaborator Author

tupek2 commented Dec 11, 2024

/style

1 similar comment
@tupek2
Copy link
Collaborator Author

tupek2 commented Dec 12, 2024

/style

@tupek2 tupek2 force-pushed the tupek/cutback_bcs_when_solve_fails branch from e17afee to 05e712f Compare December 16, 2024 23:51
@tupek2
Copy link
Collaborator Author

tupek2 commented Dec 16, 2024

/style

@tupek2 tupek2 force-pushed the tupek/cutback_bcs_when_solve_fails branch 2 times, most recently from 45bc616 to 27bf1ce Compare December 20, 2024 23:27
@tupek2 tupek2 force-pushed the tupek/cutback_bcs_when_solve_fails branch from 27bf1ce to 095f104 Compare December 20, 2024 23:58
@tupek2
Copy link
Collaborator Author

tupek2 commented Dec 20, 2024

/style

@tupek2 tupek2 added the ready for review Ready for active inspection by reviewers label Dec 23, 2024
@tupek2 tupek2 requested a review from btalamini December 23, 2024 16:56
@tupek2 tupek2 removed the WIP Work in progress label Dec 23, 2024
@tupek2 tupek2 requested review from ebchin and white238 December 23, 2024 17:55
Copy link
Member

@ebchin ebchin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good @tupek2

@@ -27,6 +27,16 @@

namespace serac {

/// @brief simple utility for computing matrix norm
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we put this somewhere else? Though not sure if we have a good place for it now.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like this isn't being used anywhere. Maybe we can take it out?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready for review Ready for active inspection by reviewers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants