Fix Racing Condition

Lakr233 · Aug 16, 2024 · 5d4b1a5 · 5d4b1a5
1 parent bfbafcf
commit 5d4b1a5
Showing 1 changed file with 9 additions and 5 deletions.
diff --git a/Sources/ColorfulX/AnimatedMulticolorGradientView.swift b/Sources/ColorfulX/AnimatedMulticolorGradientView.swift
@@ -139,17 +139,17 @@ open class AnimatedMulticolorGradientView: MulticolorGradientView {
 
     // MARK: - RENDER LIFE CYCLE
 
+    private let updateParametersLock = NSLock()
+
     override public func layoutSublayers(of layer: CALayer) {
         super.layoutSublayers(of: layer)
 
-        // skip any vsync check and force an update
+        updateParametersLock.lock()
         renderInputWasModified = true
         updateRenderParameters(deltaTime: deltaTimeForRenderParametersUpdate())
-        renderIfNeeded()
-    }
+        updateParametersLock.unlock()
 
-    override func renderIfNeeded() {
-        super.renderIfNeeded()
+        renderIfNeeded()
     }
 
     override func render() {
@@ -159,7 +159,11 @@ open class AnimatedMulticolorGradientView: MulticolorGradientView {
 
     override func vsync() {
         guard shouldRenderNextFrameWithinSynchornization() else { return }
+
+        updateParametersLock.lock()
         updateRenderParameters(deltaTime: deltaTimeForRenderParametersUpdate())
+        updateParametersLock.unlock()
+
         // sine the render parameters were updated, we call super.vsync to render
         super.vsync()
     }