[6주차 과제] 서예원 과제 제출합니다. #11
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
타켓 브랜치 수정하고, 다시 pr 날려주세여 |
genius00hwan
approved these changes
Aug 20, 2024
| @@ -26,10 +29,43 @@ public String createForm() { | |||
| public String create(MemberForm form) { | |||
There was a problem hiding this comment.
service 클래스를 만들었네요~~ 사용자가 회원가입을 하는건 비즈니스 로직 아닐까요? Service를 만든김에 사용자 생성을 service 클래스에서 해보세요~~
| @@ -30,6 +30,15 @@ public Optional<Member> findByName(String name) { | |||
| .findAny(); | |||
| } | |||
|
|
|||
| public Optional<Member> findByEmail(String email) { | |||
There was a problem hiding this comment.
emal이 중복된 사용자가 있으면 어떡하죠? findAny()는 너무 무책임한것 같습니다아
| @@ -28,6 +28,18 @@ private void validateDuplicateMember(Member member) { | |||
| }); | |||
| } | |||
|
|
|||
|
|
|||
| public Optional<Member> findByEmail(String email) { | |||
There was a problem hiding this comment.
validateDuplicateMember를 보고 이메일 중복 검증을 추가해보세요~~
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.