[6주차 과제] 박해원 과제 제출합니다. #17
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
genius00hwan
approved these changes
Aug 20, 2024
| @@ -27,6 +29,8 @@ public String create(MemberForm form) { | |||
| Member member = new Member(); | |||
| member.setName(form.getName()); | |||
| memberService.join(member); | |||
| member.setEmail(form.getEmail()); //추가 | |||
| member.setPassword(form.getPassword()); | |||
There was a problem hiding this comment.
setter를 지양하는게 어떨까요? 지금 상태로는 생성자만으로 충분히 요구사항을 지킬 수 있을것 같습니다!!
| //폼 데이터: 사용자가 HTML 폼을 통해 제출한 데이터, MemberForm은 사용자가 입력한 데이터를 담기위한 객체 | ||
| //모델: 컨트롤러에서 처리된 결과를 뷰에 넘겨서 표시하기 위해 사용(사용자목록) | ||
| @PostMapping(value = "/members/login") | ||
| public String loginPost(MemberForm form, Model model){ |
There was a problem hiding this comment.
이메일로 사용자를 찾고 비밀번호가 일치한지 판단하는 로직은 비즈니스 로직입니다.
일반적으로 service에서 비즈니스 로직을 수행합니다!!
| @@ -11,6 +11,8 @@ public interface MemberRepository { | |||
|
|
|||
| Optional<Member> findById(Long id); | |||
|
|
|||
| Optional<Member> findByEmail(String email); | |||
| @@ -28,4 +32,20 @@ public String getName() { | |||
| public void setName(String name) { | |||
| this.name = name; | |||
| } | |||
|
|
|||
There was a problem hiding this comment.
말했듯 최대한 setter를 지양하고 왜 setter를 지양하는지 찾아보세요!!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
제 branch로 다시 올렸습니다!