[6주차 과제] 박수지 과제 제출합니다. #7
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
타켓 브랜치 수정하고, 다시 pr 날려주세여 |
|
제가 했습니다,, |
genius00hwan
approved these changes
Aug 20, 2024
| @@ -26,9 +29,41 @@ public String createForm() { | |||
| public String create(MemberForm form) { | |||
| Member member = new Member(); | |||
| member.setName(form.getName()); | |||
There was a problem hiding this comment.
setter는 최대한 지양해주세요 생성자만으로 충분해 보입니다!!
| .findAny(); | ||
| } | ||
| @Override | ||
| public Optional<Member> findByPwd(String pwd) { |
There was a problem hiding this comment.
비밀번호로 사용자를 찾는 일이 필요할까요?
비밀번호는 같은 비밀번호를 사용할 수 있을텐데 이때 findAny()를 사용해도 될까요?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.