forked from woowacourse-precourse/java-baseball-6
-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[숫자 야구 게임] 이태균 과제 제출합니다. #3
Open
taekyun0219
wants to merge
5
commits into
LandvibeDev:main
Choose a base branch
from
taekyun0219:taekyun0219
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,7 +1,83 @@ | ||
package baseball; | ||
|
||
import camp.nextstep.edu.missionutils.Randoms; | ||
import camp.nextstep.edu.missionutils.Console; | ||
|
||
import java.util.ArrayList; | ||
import java.util.List; | ||
|
||
public class Application { | ||
|
||
public static void Game(){ | ||
while(true){ | ||
System.out.println("숫자 야구 게임을 시작합니다."); | ||
List<Integer> computer = new ArrayList<>(); //랜덤 숫자 리스트 | ||
while (computer.size() < 3) { | ||
int randomNumber = Randoms.pickNumberInRange(1, 9); | ||
if (!computer.contains(randomNumber)) { | ||
computer.add(randomNumber); | ||
} | ||
} | ||
while(true){ | ||
System.out.println("숫자를 입력해주세요 : "); | ||
String input = Console.readLine(); | ||
int in = Integer.parseInt(input); | ||
if (in < 0 || in > 999) { | ||
throw new IllegalArgumentException(); | ||
} | ||
int[] num = new int[3]; //입력 숫자 리스트 | ||
for(int i = 0; i < 3; i++){ | ||
num[i] = input.charAt(i) - '0'; | ||
} | ||
|
||
String result = Go(computer,num); | ||
|
||
System.out.println(result); | ||
if(result.equals("3스트라이크")){ | ||
break; | ||
} | ||
} | ||
System.out.println("3개의 숫자를 모두 맞히셨습니다! 게임 종료"); | ||
System.out.println("게임을 새로 시작하려면 1, 종료하려면 2를 입력하세요."); | ||
String next = Console.readLine(); | ||
if (next.equals("2")) { | ||
break; | ||
} | ||
else if(!next.equals("1")){ | ||
continue; | ||
} | ||
} | ||
} | ||
public static String Go(List<Integer> computer, int[] input){ | ||
int strike = 0; | ||
int ball = 0; | ||
for(int i = 0; i < 3; i++){ | ||
for(int j = 0; j < 3; j++){ | ||
if(computer.get(i).equals(input[j])){ | ||
if(i == j){ | ||
strike++; | ||
} | ||
else{ | ||
ball++; | ||
} | ||
} | ||
} | ||
} | ||
if(ball == 0 && strike == 0){ | ||
return "낫싱"; | ||
} | ||
else if(strike == 0){ | ||
return ball + "볼"; | ||
} | ||
else if(ball == 0){ | ||
return strike + "스트라이크"; | ||
} | ||
else{ | ||
return ball + "볼 " + strike + "스트라이크"; | ||
} | ||
|
||
} | ||
public static void main(String[] args) { | ||
// TODO: 프로그램 구현 | ||
Game(); | ||
} | ||
} |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
모든 기능이 한 클래스에 집중되어 있습니다. 객체지향적 설계를 생각해보고 관심사의 분리를 적용해보세요~~!!
야구게임을 진행할때, 필요한 객체, 기능들을 생각해보면 리팩토링 가능할 것 같습니다!!