Split build and test CI entry point from workflow to provide a reusable interface #144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #144 +/- ##
=======================================
Coverage 88.46% 88.46%
=======================================
Files 5 5
Lines 78 78
Branches 20 20
=======================================
Hits 69 69
Misses 9 9
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
fbeutin-ledger
force-pushed
the
fbe/reusable_entry_point_for_CI
branch
from
a4db3ea to
e68dfb1
Compare
fbeutin-ledger
force-pushed
the
fbe/reusable_entry_point_for_CI
branch
from
e68dfb1 to
38f364e
Compare
Comment on lines
4
to
6
| # | ||
| # The build part of this workflow is mandatory, this ensures that the app will be deployable in the Ledger App Store. | ||
| # While the test part of this workflow is optional, having functional testing on your application is mandatory and this workflow and |
There was a problem hiding this comment.
I'm wondering if we should move this part to the other workflow?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.