💄 Ledger Sync copy and UX improvements #8916
Open
+19
−31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 4 Skipped Deployments
|
live-github-bot
bot
added
desktop
cgrellard-ledger
force-pushed
the
support/ledger-sync-copy-and-ux-improvements
branch
from
2509883 to
5a8a9b4
Compare
KVNLS
requested changes
Jan 16, 2025
Comment on lines
21
to
+23
| const onPressSyncAccounts = () => onSyncMethodPress(); | ||
|
|
||
| const onPressHasAlreadyCreatedAKey = () => onSyncMethodPress(); | ||
| const onPressHasAlreadyCreatedAKey = () => navigateToChooseSyncMethod(); |
There was a problem hiding this comment.
Why do we redefine a new function at each render?
I think that we can use the one passed as props directly in the jsx, isn't it?
mcayuelas-ledger
requested changes
Jan 16, 2025
| @@ -21,7 +21,7 @@ function View() { | |||
| marginTop: 114, | |||
| }} | |||
| > | |||
| <Activation onSyncMethodPress={onOpenDrawer} /> | |||
| <Activation onSyncMethodPress={onOpenDrawer} navigateToChooseSyncMethod={onOpenDrawer} /> | |||
There was a problem hiding this comment.
What's the difference?
We should have different analytics no?
or do another action?
There was a problem hiding this comment.
The tracking is done in the children component and will be different for each button but we have to pass two different methods in the other place where we're using the Activation component
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✅ Checklist
npx changesetwas attached.📝 Description
Updated copy on LLM and LLD
Removed entry points in accounts page on LLD
Skip unnecessary step on LLM when clicking on
Turn on Ledger SyncScreen.Recording.2025-01-15.at.18.27.10.mov
❓ Context
🧐 Checklist for the PR Reviewers