Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SWAP] Handle spl token swap #8939

Draft
wants to merge 1 commit into
base: feat/solana-tokens-support-squashed
Choose a base branch
from

Conversation

sprohaszka-ledger
Copy link
Contributor

@sprohaszka-ledger sprohaszka-ledger commented Jan 17, 2025

✅ Checklist

  • npx changeset was attached.
  • Covered by automatic tests.
  • Impact of the changes:
    • ...

📝 Description

Replace this text by a clear and concise description of what this pull request is about and why it is needed. Be sure to explain the problem you're addressing and the solution you're proposing.
For libraries, you can add a code sample of how to use it.
For bug fixes, you can explain the previous behaviour and how it was fixed.
In case of visual features, please attach screenshots or video recordings to demonstrate the changes.

❓ Context


🧐 Checklist for the PR Reviewers

  • The code aligns with the requirements described in the linked JIRA or GitHub issue.
  • The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
  • There are no undocumented trade-offs, technical debt, or maintainability issues.
  • The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
  • Any new dependencies have been justified and documented.
  • Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)

Signed-off-by: Stéphane Prohaszka <[email protected]>
Copy link

vercel bot commented Jan 17, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
web-tools ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 17, 2025 2:03pm
3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
ledger-live-github-bot ⬜️ Ignored (Inspect) Visit Preview Jan 17, 2025 2:03pm
native-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Jan 17, 2025 2:03pm
react-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Jan 17, 2025 2:03pm

@live-github-bot live-github-bot bot added common Has changes in live-common ledgerjs Has changes in the ledgerjs open source libs cli labels Jan 17, 2025
@live-github-bot
Copy link
Contributor

live-github-bot bot commented Jan 17, 2025

Desktop Bundle Checks

Comparing 0d04d4a against a8e2a6d.

🚀 renderer bundle size decreased (38mb -> 37.8mb). Thanks ❤️

Mobile Bundle Checks

Comparing 0d04d4a against a8e2a6d.

🚀 main.ios.jsbundle bundle size decreased (62mb -> 61.8mb). Thanks ❤️
🚀 main.android.jsbundle bundle size decreased (62mb -> 61.8mb). Thanks ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cli common Has changes in live-common ledgerjs Has changes in the ledgerjs open source libs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant