Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

node limit passed as 0 instead of a negative number to visits_stopper if nn cache > memory limit (prevents unsigned int variable overflow) #2058

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

node limit passed as 0 instead of a negative number to visits_stopper if nn cache > memory limit (prevents unsigned int variable overflow) #2058

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
02b956a
node limit passed as 0 instead of a negative number to visits_stopper…
KarlKfoury Aug 30, 2024
2075e0d
adding missing parentheses
KarlKfoury Aug 30, 2024
d1bedd7
removing extra parentheses
KarlKfoury Aug 30, 2024
3516c0b
remove chrono inclusion
KarlKfoury Aug 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion src/mcts/search.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,6 @@

#include <algorithm>
#include <array>
#include <chrono>
#include <cmath>
#include <iomanip>
#include <iostream>
Expand Down
3 changes: 2 additions & 1 deletion src/mcts/stoppers/stoppers.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,7 +104,8 @@ MemoryWatchingStopper::MemoryWatchingStopper(int cache_size, int ram_limit_mb,
bool populate_remaining_playouts)
: VisitsStopper(
(ram_limit_mb * 1000000LL - cache_size * kAvgCacheItemSize) /
kAvgNodeSize,
kAvgNodeSize > 0 ? (ram_limit_mb * 1000000LL - cache_size * kAvgCacheItemSize) /
kAvgNodeSize : 0,
populate_remaining_playouts) {
LOGFILE << "RAM limit " << ram_limit_mb << "MB. Cache takes "
<< cache_size * kAvgCacheItemSize / 1000000
Expand Down