Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add meta data to pipeline. #42

Merged
merged 21 commits into from
Nov 25, 2024
Merged

feat: add meta data to pipeline. #42

merged 21 commits into from
Nov 25, 2024

Conversation

pekasen
Copy link
Member

@pekasen pekasen commented Apr 19, 2024

Adds a Record-class with which data is wrapped and meta data are gathered through the pipeline. Adds additional tests for Record.py, NDJSONReader.py and TwacapicReader.py.

Coverage is now 60%

@pekasen
feat: add meta data to pipeline.
4cc9fd0 
Adds a Record-class with which data is wrapped and meta data are gathered through the pipeline.
Adds additional tests for Record.py, NDJSONReader.py and TwacapicReader.py.

Coverage is now 60%
@pekasen pekasen added the enhancement New feature or request label Apr 19, 2024
@pekasen pekasen requested a review from FlxVctr April 19, 2024 15:35
@pekasen pekasen self-assigned this Apr 19, 2024
@pekasen pekasen linked an issue Apr 19, 2024 that may be closed by this pull request
feat: transport metadata and emit diagnostics #39
Closed
FlxVctr
FlxVctr approved these changes Jul 4, 2024
View reviewed changes
Copy link
Member

@FlxVctr FlxVctr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks alright, but untested by me. Would be good to find a way to get the CI checks running on GH

dabapush/Record.py Outdated Show resolved Hide resolved
@pekasen
Copy link
Member Author

pekasen commented Jul 4, 2024 •
edited
Loading

looks alright, but untested by me. Would be good to find a way to get the CI checks running on GH

Yep, CI testing hangs itself on the dependency to smo-database, which is a private git-submodule as of yet. #45 removes this and testing is then available in CI.

@pekasen pekasen merged commit 8fb857b into trunk Nov 25, 2024
2 checks passed
@pekasen pekasen deleted the 39-feat-transport-metadata-and-emit-diagnostics branch November 25, 2024 12:55
@pekasen pekasen mentioned this pull request Nov 25, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FlxVctr FlxVctr FlxVctr approved these changes

Assignees

@pekasen pekasen

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feat: transport metadata and emit diagnostics
2 participants
@pekasen @FlxVctr