-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(iOS): Support system media control #220
Conversation
Reviewer's Guide by SourceryThis pull request introduces support for system media controls on iOS. It updates the dependencies and platform-specific code to integrate with the iOS system UI for media playback control. Sequence diagram for iOS media control interactionsequenceDiagram
participant User as User
participant System as iOS System Controls
participant App as Rune Player
participant Audio as Audio Session
Note over App: Initialize
App->>Audio: initAudioSession()
Audio-->>App: Session Active
User->>System: Interact with media controls
System->>App: Send control event
App->>App: Handle media control
App-->>System: Update playback state
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @XMLHexagram - I've reviewed your changes - here's some feedback:
Overall Comments:
- Consider using an official versioned release of souvlaki instead of a git dependency to ensure build reproducibility and security
- The PR description mentions test updates but no test changes are visible in the diff. Please include the relevant test coverage changes
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Summary by Sourcery
Add support for system media controls on iOS.
New Features:
Tests: