Client cert authentication flow #90
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Just to note, it might be worth making a note in the documentation if this pull is approved. MSAL.PS does not support all certificates. I attempted to set this up in our environment and we had to create non-CNG certificates for MSAL.PS to work. It has something to do with the version of .Net the module was written in. If you are OK creating non-CNG this change will work. We don't want more issues coming to this repository for an issue that belongs upstream. Please reference AzureAD/MSAL.PS#67 |
|
Thank you for creating this PR! It's been on my todo-list, but I've not really prioritized it yet, so thank you. I'll merge this now :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a client cert authentication flow to Connect-MSIntuneGraph via a clientCert parameter set. Much safer than Client Secret and follows best practices.