Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: check required setting values during mod settings deserialization #278

Open
wants to merge 5 commits into
base: development
Choose a base branch
from
Open

fix: check required setting values during mod settings deserialization #278

wants to merge 5 commits into from

Conversation

LordMidas
Copy link
Member

@LordMidas LordMidas commented Jan 20, 2023 •
edited
Loading

No description provided.

@LordMidas LordMidas requested review from TaroEld and Enduriel January 20, 2023 05:48
@Enduriel Enduriel added this to the 1.2.0-rc.3 milestone Jan 25, 2023
@LordMidas LordMidas requested a review from Enduriel January 26, 2023 08:08
TaroEld
TaroEld approved these changes Jan 26, 2023
View reviewed changes
Copy link
Member

@TaroEld TaroEld left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved after string formats

msu/systems/mod_settings/mod_settings_system.nut Outdated Show resolved Hide resolved
msu/systems/mod_settings/mod_settings_system.nut Outdated Show resolved Hide resolved
Enduriel
Enduriel approved these changes Jan 29, 2023
View reviewed changes
Copy link
Member

@Enduriel Enduriel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One last commit for minor fixes, merge in after.

msu/systems/mod_settings/mod_settings_system.nut Show resolved Hide resolved
msu/systems/mod_settings/mod_settings_system.nut Outdated Show resolved Hide resolved
@LordMidas
Copy link
Member Author

Although this PR is approved, I do not want to merge it yet. As I brought up on the Discord, we need to discuss about ways to register and release requirements for values. Secondly, I believe we shouldn't be serializing the Locked state of a setting. Both of these points need to be discussed @TaroEld , @Enduriel .

This was referenced Feb 1, 2023
Open
Open
@LordMidas LordMidas removed this from the 1.2.0-rc.3 milestone Feb 6, 2023
@LordMidas LordMidas added the postponed Something to work on eventually, but not now label Feb 6, 2023
@LordMidas LordMidas changed the base branch from release to development February 28, 2023 05:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Enduriel Enduriel Enduriel approved these changes

@TaroEld TaroEld TaroEld approved these changes

Assignees
No one assigned
Labels
postponed Something to work on eventually, but not now
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@LordMidas @TaroEld @Enduriel