Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add type checker for unsigned integers #336

Open
wants to merge 2 commits into
base: development
Choose a base branch
from
Open

feat: add type checker for unsigned integers #336

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e785dae
feat: add type checker for unsigned integers
Feb 17, 2024
0fa21c8
refactor: rename function and improve exception feedback
Mar 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions msu/utils/type_checkers.nut
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,19 @@
::MSU.requireTypeArray("integer", vargv);
}

::MSU.requireUnsigned <- function( ... )
{
::MSU.requireTypeArray("integer", vargv);
Copy link
Author

@Darxo Darxo Mar 4, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will say this use of the existing require check only seemed good back then.
But in reality this means that failing an unsigned integer check will print a "failed an integer check" message half the time. And that is not fully correct.

Ideally we would copy&paste the integer check logic in this check but swap out the printed exception

foreach (value in vargv)
{
if (value < 0)
{
::logError(value + " must have the type: unsigned");
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd argue unsigned isn't actually a type and therefore the error should be something more like.

value + " must have the type: integer, and be greater than or equal to 0"

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In that same vein what about the function name? Should it be something like requireUInt?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah maybe that's better too

throw ::MSU.Exception.InvalidType(value);
}
}
}

::MSU.requireArray <- function( ... )
{
::MSU.requireTypeArray("array", vargv);
Expand Down