-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[API Histologe] Améliorations route GET + Documentation #3524
base: develop
Are you sure you want to change the base?
Conversation
76e6bb4
to
6dad4b7
Compare
public ?string $territoireNom; | ||
#[OA\Property( | ||
description: 'Correspond au code insee du département<br> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
code géographique
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pourquoi ajouter un exemple ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
L’appellation vient de ce wiki
https://fr.wikipedia.org/wiki/Codes_g%C3%A9ographiques_de_la_France
L'exemple dans la doc est pour clarifier l’appellation code insee du département.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Quelques retours et questions, pas encore testé !
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Quelques retours, bel effort et beau travail de doc.
description: 'Classe énergétique du logement selon le diagnostic de performance énergétique (DPE). | ||
<ul> | ||
<li>La valeur doit être une lettre entre `A` et `G` selon la nomenclature du DPE</li> | ||
<li>`null` si aucune information.</li> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Il y'a aussi la possibilité "nsp" ("Ne sait pas"). D'ailleurs on pourrais renvoyer la valeur "Ne sait pas" en rajoutant le bon paramètre via getBailDpeClasseEnergetique
mais il faudrait généraliser a tout ces type de retour donc je ne sais pas si on le fait ou pas ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Je pense avoir fait le tour des nsp
j'ai donc mis à jour la méthode afin de retourner les nsp
private function stringToBool(?string $value): bool|string|null {
6e9ded3
to
f659b31
Compare
Quality Gate passedIssues Measures |
Ticket
#3424
Description
Changements apportés
Pré-requis
Tests
Documentation
Configuration
baseUrl
etbearerToken
et sauvgearder