Fix vhu identifications inputs

MTES-MCT · Jan 6, 2025 · 8949788 · 8949788
1 parent 9f61133
commit 8949788
Show file tree

Hide file tree

Showing 2 changed files with 21 additions and 8 deletions.
diff --git a/Changelog.md b/Changelog.md
@@ -11,6 +11,10 @@ et le projet suit un schéma de versionning inspiré de [Calendar Versioning](ht
 
 - Pour le Bsvhu lors d'un transport routier, la plaque d'immatriculation est désormais obligatoire et les poids de déchets sont limités à 40 T (50 kT pour les autres modes) [PR 3719](https://github.com/MTES-MCT/trackdechets/pull/3719)
 
+#### :bug: Corrections de bugs
+
+- Correction de la mise à jour des numéros d'identification sur le bsvhu [PR 3876](https://github.com/MTES-MCT/trackdechets/pull/3876)
+
 # [2024.12.1] 17/12/2024
 
 #### :rocket: Nouvelles fonctionnalités

diff --git a/front/src/Apps/Forms/Components/IdentificationNumbers/IdentificationNumber.tsx b/front/src/Apps/Forms/Components/IdentificationNumbers/IdentificationNumber.tsx
@@ -29,22 +29,27 @@ const IdentificationNumber = ({
   function identificationNumberReducer(state, action) {
     switch (action.type) {
       case SET_INPUT_CODE:
-        return { ...state, inputCode: action.payload };
+        return { ...state, inputCode: action.payload, touched: true };
+
       case ADD_CODE: {
-        if (!state.codes.length && defaultValue?.length) {
+        if (!state.codes.length && defaultValue?.length && !state.touched) {
+          // initial
           return {
             ...state,
             codes: [...state.codes, ...defaultValue],
-            inputCode: ""
+            inputCode: "",
+            touched: true
           };
         }
         if (!state.inputCode || state.codes.includes(state.inputCode)) {
           return state;
         }
+
         return {
           ...state,
           codes: [...state.codes, state.inputCode],
-          inputCode: ""
+          inputCode: "",
+          touched: true
         };
       }
       case REMOVE_CODE: {
@@ -53,7 +58,7 @@ const IdentificationNumber = ({
 
         return {
           ...state,
-          codes
+          codes: [...codes]
         };
       }
     }
@@ -81,7 +86,8 @@ const IdentificationNumber = ({
 
   const [state, dispatch] = useReducer(identificationNumberReducer, {
     codes: getValues(name),
-    inputCode: ""
+    inputCode: "",
+    touched: false
   });
 
   useEffect(() => {
@@ -116,8 +122,11 @@ const IdentificationNumber = ({
             className="fr-mr-2v"
             nativeButtonProps={{
               type: "button",
-              onClick: () =>
-                !disabled && dispatch({ type: REMOVE_CODE, payload: idx }),
+              onClick: () => {
+                return (
+                  !disabled && dispatch({ type: REMOVE_CODE, payload: idx })
+                );
+              },
               ...{ "data-testid": "tagInputIdentificationNumber" }
             }}
           >