-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
code _for 2W #2
base: master
Are you sure you want to change the base?
code _for 2W #2
Conversation
commit b673e82 Author: Maged Eltorkoman <[email protected]> Date: Fri Feb 25 11:10:39 2022 +0200 Feat: save and load for alpha and conditions commit 8d61187 Author: Maged Eltorkoman <[email protected]> Date: Fri Feb 25 09:04:23 2022 +0200 Bug: Make logger hidden in ci_matrix commit 8433efc Author: Maged Eltorkoman <[email protected]> Date: Wed Feb 23 21:39:43 2022 +0200 Tried SCIP solver in splitting benchmark_splitting commit 65f66df Merge: 900f087 2cbb1de Author: Maged Turkoman <[email protected]> Date: Tue Feb 15 10:29:54 2022 +0200 Merge pull request #1 from MagedMohamedTurk/test-binder-env Update environment.yml commit 2cbb1de Author: Maged Turkoman <[email protected]> Date: Tue Feb 15 10:20:46 2022 +0200 added plotting packages commit 493b835 Author: Maged Turkoman <[email protected]> Date: Tue Feb 15 10:09:21 2022 +0200 Update environment.yml commit 900f087 Author: Maged Turkoman <[email protected]> Date: Tue Feb 15 10:03:53 2022 +0200 Docs: update readme with mybinder link
Self=(B-A) @ inv(U)
@@ -148,6 +148,7 @@ def _info(self): | |||
index=_index, columns=_columns)) | |||
if self.U is not None: | |||
_index = (f'Plane {n+1}' for n in range(self.U.shape[0])) | |||
_columns = (f'Plane {n+1}' for n in range(self.U.shape[1]) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing closing parenthesis
@@ -78,7 +78,7 @@ def add(self, direct_matrix:'np.array'=None, A:'initial_vibration numpy.array'=N | |||
self.B = B | |||
self.U = U | |||
if not keep_trial: | |||
self.value = (self.B - self.A) / self.U | |||
self.value = (self.B - self.A) @ np.linalg.inv(self.U) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work @shoaibmahmod7
Inverse matrix will only work on square matrices. I think to do your implementation of multiple trial weights on more than one plane, we need to make the square matrix to be the default.
So the original trial vector can be a square zero matrix with the diagonal to be the values of the trials at each plane.
U = [1, 2, 3] --> U =[[1, 0, 0], [0, 2, 0], [0, 0, 3]]
This will not break the structure of the package and still we can apply your idea.
I think this is doable.
`import logging
import warnings
import numpy as np
import hsbalance.tools as tools
import pandas as pd
import pickle
_logger = logging.getLogger(name)
_logger.propagate = False
_logger.setLevel(logging.DEBUG)
_console_handle = logging.StreamHandler()
_console_handle.setLevel(logging.INFO)
_logger.addHandler(_console_handle)
pd.set_option('display.max_columns', 1000) # Set maximum number of columns to 1000
class Alpha():
class Condition():
`