[FIX] 케이크 선물하기 #146
Merged
[FIX] 케이크 선물하기 #146
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yujindonut
approved these changes
Dec 2, 2023
| public CakeCreateResponseDTO createPresentNew(CakeCreateRequest request) { | ||
| val cake = getCake(request.cakeId()); | ||
| val wish = wishService.getWish(request.wishId()); | ||
| val present = new Present(request.name(), request.message(), wish, cake); |
There was a problem hiding this comment.
Present는 Builder 패턴을 이용하는 것으로 알고 있는데, builder 패턴을 이용하는건 어떨까요?
Present.builder()
.name(request.name())
.message(request.message())
.wish(wish)
.cake(cake)
.build()
이런느낌으로 생성자 패턴이 통일되면 더 좋을 것 같습니다~!
| @@ -31,4 +31,8 @@ private static LocalDateTime convertToTime(String dateTime) throws DateTimeParse | |||
| .atZone(ZoneId.of("Asia/Seoul")); | |||
| return LocalDateTime.from(instant); | |||
| } | |||
|
|
|||
| public static String calculateContribution(int price, int targetPrice) { | |||
| return String.format("%.0f", (double) price / (double) targetPrice * 100); | |||
There was a problem hiding this comment.
double은 한쪽에만 붙이고 괄호처리를 하여도 double로 계산이 된다고 알고있습니다!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✨ 관련 이슈
closed #145
✨ 변경 사항 및 이유
✨ PR Point
createPresentNew라는 함수를 만들었습니다.Util에 넣었습니다.