Add "when" arguments to define-obsolete-variable-alias invocations #249
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The WHEN argument is mandatory in Emacs 28 (as of commit 32c6732d16385f242b1109517f25e9aefd6caa5c).
|
Thank you for sharing this update, I've been confused by the error for a while and I didn't know what the issue was! |
|
@Malabarba may I kindly ask if you got a chance to look into this PR? |
|
Up :) |
|
Fixes #251 |
|
Merged! Sorry for the radio silence. I confess I didn't get this error even though I'm on the latest emacs builds. But I guess it's because SML hasn't had updates and the error is only during byte-compilation? |
Correct ... the error appears on during byte-compilation. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See: emacs-mirror/emacs@32c6732