Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add network interface loopback #254

Merged
merged 1 commit into from
Aug 13, 2024

Conversation

agrare
Copy link
Member

@agrare agrare commented Aug 6, 2024

Allow callers to filter out loopback interfaces, e.g. ManageIQ/manageiq-appliance_console#263

This is built on the JSON change so be37dcb is the relevant commit here

Depends on:

Related: ManageIQ/manageiq-appliance-build#573

@miq-bot miq-bot added the wip label Aug 6, 2024
@agrare agrare force-pushed the add_network_interface_loopback branch from 03c9a3c to be37dcb Compare August 13, 2024 17:36
@agrare agrare changed the title [WIP] Add network interface loopback Add network interface loopback Aug 13, 2024
@agrare agrare added enhancement and removed wip labels Aug 13, 2024
@agrare agrare requested review from Fryguy and bdunne August 13, 2024 17:36
@agrare agrare force-pushed the add_network_interface_loopback branch from be37dcb to 2ea00f4 Compare August 13, 2024 19:17
@miq-bot
Copy link
Member

miq-bot commented Aug 13, 2024

Checked commit agrare@2ea00f4 with ruby 3.1.5, rubocop 1.56.3, haml-lint 0.51.0, and yamllint
1 file checked, 0 offenses detected
Everything looks fine. 👍

@bdunne bdunne self-assigned this Aug 13, 2024
@bdunne bdunne merged commit 2881257 into ManageIQ:master Aug 13, 2024
5 checks passed
@agrare agrare deleted the add_network_interface_loopback branch August 13, 2024 19:38
bdunne added a commit that referenced this pull request Aug 13, 2024
Breaking Changes:
- Use --json for ip command output #251

Added:
- Add network interface loopback #254
- Add LinuxAdmin::NetworkInterface.list #249

Changed:
- Parse config file on NetworkInterface#reload #253

Test:
- Use ruby 3.1 and rails 7 for code coverage #250
- Fix rubocop warnings in NetworkInterface Spec #252
- Update paambaati/codeclimate-action action to v8 #248
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants