Fix ip_route for appliction_console

[kbrock]

On typical systems, ip_route calls ip route show default On the mac, ip_route calls ip route get while

This fixes ip_route from failing and fixes an appliance_console bug

before

# LinuxAdmin::NetworkInterface.list
route: writing to routing socket: not in table (LinuxAdmin::NetworkInterfaceError)
 error was: route: writing to routing socket: not in table
 error was: route: writing to routing socket: not in table

	from /Users/kbrock/src/gems/linux_admin/lib/linux_admin/network_interface.rb:26:in `list'
	from (irb):2:in `<main>'
	from <internal:kernel>:187:in `loop'
	from railties (7.0.8.6) lib/rails/commands/console/console_command.rb:74:in `start'
	from railties (7.0.8.6) lib/rails/commands/console/console_command.rb:19:in `start'

after

# LinuxAdmin::NetworkInterface.list.first
=>
#<LinuxAdmin::NetworkInterfaceDarwin:0x0000000163fd2d98
 @interface="lo0",
 @link_type="loopback",
 @network_conf={:address=>"127.0.0.1", :prefix=>8, :mac=>"00:00:00:00:00:00", :gateway4=>"192.168.1.1", :gateway6=>"fe80::%utun0"}>

[miq-bot]

Some comments on commit kbrock@e9e80e9

spec/network_interface_spec.rb

• ⚠️ - 45 - Detected allow_any_instance_of. This RSpec method is highly discouraged, please only use when absolutely necessary.

[miq-bot]

Checked commit kbrock@e9e80e9 with ruby 3.1.5, rubocop 1.56.3, haml-lint 0.51.0, and yamllint
7 files checked, 4 offenses detected

lib/linux_admin/distro.rb

• ❗ - Line 26, Col 7 - Naming/MemoizedInstanceVariableName - Memoized variable @distros does not match method name all. Use @all instead.

lib/linux_admin/homebrew.rb

• ❗ - Line 16, Col 31 - Style/RedundantArgument - Argument " " is redundant because it is implied by default.
• ❗ - Line 22, Col 1 - Layout/TrailingWhitespace - Trailing whitespace detected.
• ❗ - Line 4, Col 1 - Layout/TrailingWhitespace - Trailing whitespace detected.

[Fryguy]

Look like you have a bonus line at the end here.

[Fryguy]

I wonder if this is cleaner as:

Suggested change

	if [Distros.rhel, Distros.fedora].include?(Distros.local)
	NetworkInterfaceRH
	elsif Distros.local == Distros.darwin
	NetworkInterfaceDarwin
	case Distros.local
	when Distros.rhel, Distros.fedora
	NetworkInterfaceRH
	when Distros.darwin
	NetworkInterfaceDarwin

[Fryguy]

Overall looks good - can you add specs for ip_route method?

[Fryguy]

My only other thought is, if we're going all the way to Darwin, should we try to avoid having to install iproute2mac, and use the built-in tools instead?

[agrare]

I do think at a high level we need to answer "do we want linux_admin to work on mac?" (emphasis on linux here)

We can get some of the networking commands to work but there are some other command sets which will not (systemd vs old init.d service, rpm packages, etc...) and we could need something like supports here.

[agrare]

I think the easy answer is "if it isn't difficult to get it to work we might as well" but how far do we want to go in order to get it to work?
Also the specs should 100% be able to be run on a mac (here and appliance_console).

[Fryguy]

I'm ok with bringing in things bit by bit to support Mac. Heck, I'd be ok with supporting WSL too at some point :)

Agreed on something like supports here would be good. At a minimum we just raise NotImplementedError for certain things.