Remove dup check from throw_bounds_warning
#3728
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MDEV-11917 merged a unified `const char*` overload for the two numeric `throw_bounds_warning` overloads. The `my_error`-on- `MODE_STRICT_ALL_TABLES` branch wasn’t removed from the two, though. This commit removes this leftover duplication.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Jira issue number for this PR is: MDEV-11917Description
MDEV-11917 merged a unified
const char*overload for the two numericthrow_bounds_warningoverloads. Themy_error-on-MODE_STRICT_ALL_TABLESbranch wasn’t removed from the two, though.In result, the two checks if they should switch to this branch before calling the unified overload, but its first action is also to check if it should switch to a branch with the exact same (assembly) code.
This commit removes this leftover duplication.
Release Notes
N/A – This is a miscellaneous refactor with no output changes.
How can this PR be tested?
Run existing MTR tests
Basing the PR against the correct MariaDB version
mainbranch.PR quality check
(I filed this tiny diff as a PR because of good habit… 😀)