corec: force the max alignment on the array elements #205
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robUx4
force-pushed
the
maxalign
branch
2 times, most recently
from
5ae5268 to
9407471
Compare
It should always be a pointer with the highest alignment the compiler support so should be able to hold any kind of pointer.
It's never used and always .
We don't need it on Linux or macOS.
We can make dataheaphead private and remove remaining pointer arithmetics.
It's cleaner than an extern variable. The linker may optimize this.
Otherwise we won't be able to read back the cc_memheap* from the p->_Begin shift.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MSVC supports
stdalign.hin C11 mode: https://learn.microsoft.com/en-us/cpp/c-language/alignment-c?view=msvc-170The zero-sized array (flexible array) is supported by MSVC (and gcc and clang) with a warning: https://learn.microsoft.com/en-us/cpp/error-messages/compiler-warnings/compiler-warning-levels-2-and-4-c4200?view=msvc-170. It's only a level 4 warning in C, it's not that dirty just pay attention to use it properly.