New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Default Multiplicity and deal with circular references #14

Open

jamesrwelch wants to merge 3 commits into develop from feature/defaultMultiplicity

jamesrwelch commented Jan 30, 2023

Generate types for classes where multiplicity is not set, use 0 and 1 as default min / max respectively.
When dealing with reference data types, don't risk looping forever; instead assume a type will be generated for the referenced class and just insert its name

jamesrwelch added 2 commits

January 30, 2023 14:44


          If not multiplicity has been set, use some default values

f794cc0


          Fix an issue where dealing with reference classes might enter a circu…

89e94cb

…lar state and run out of heap space

jamesrwelch requested a review from joe-crawford

January 30, 2023 14:48


          Update license for the new year

cb05116

Contributor

joe-crawford commented Jan 30, 2023

The code changes look good to me but looks like the tests are failing, probably because more classes are now able to be exported?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet