Chat/Console message appears when a building is completed #189
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andy5995
reviewed
May 4, 2019
| @@ -2039,6 +2039,12 @@ void Unit::born(const CommandType *ct) { | |||
| faction->applyStaticProduction(type,ct); | |||
| setCurrSkill(scStop); | |||
|
|
|||
| if(ct != NULL && (ct->getClass() == ccBuild || ct->getClass() == ccRepair)) { | |||
| //assume this is a building. This could lead to problems in the future, | |||
| //but there is no real way to detect a building | |||
There was a problem hiding this comment.
That's maybe not a bad thing if it detects everything, not just buildings. If players also get notified when a Thor statue is completed, or a wicker behemoth, that could be helpful too.
But then the output message may need to be more generic.
|
Question marks appear on each side of the message
|
|
I accidentally tested this PR in a network MP game, and was recording at the time. Video at https://www.twitch.tv/videos/496304434 I'd have to review it a little, but I think that the player can see when enemy buildings are completed as well. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Displaying a message on chat/console when a building finishes.
Any more ideas? I would add them here, before we accept the pull request.
Also see https://forum.megaglest.org/index.php?topic=9721.0