-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add clickable unit portraits #231
base: develop
Are you sure you want to change the base?
Conversation
clicking on a unit portrait selects that unit shift clicking on it, deselects it
@Rampoina New method select type is not working, megaglest-source/source/glest_game/gui/gui.cpp Line 1225 in 68fb4cd
it's works fine! so better, will be create method select type in Gui.cpp and put there encapsulated code from line above |
@pavanvo please tell me what are you testing and the steps to reproduce the issue. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works for me!
Nice! Thanks @Rampoina
@Rampoina what do you think about using right-click instead of shift-click when removing selected units? |
so, may also "select type" with double click? |
Definitely not instead of, those are the standard bindings in most games. I see no harm in adding it as an alternative though. Double click feels intuitive but I'm not so sure about right click |
fixes #222