-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/non blocking for loading game info #240
Open
pavanvo
wants to merge
8
commits into
MegaGlest:develop
Choose a base branch
from
pavanvo:feat/non_blocking
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
3c5f33d
feat: add class CallBack
632c670
feat: add loadAsync method to XmlTree class
edbee7c
feat: load game non-bloking
f891ad9
feat: loading indicator
73814e3
feat: disable game slots buttons
4f86eac
style: tabs insted of spaces
e7610e4
fix: #include <memory> for modern compilers
99c5529
fix: disable 'load button' while loading game xml
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,70 @@ | ||
#pragma once | ||
|
||
#include <functional> | ||
#include <thread> | ||
#include <utility> | ||
|
||
using std::function; | ||
using std::thread; | ||
|
||
namespace Shared{ namespace Util{ | ||
|
||
template<typename T> | ||
class CallBack { | ||
|
||
|
||
private: | ||
function<void()> _onThen = [](){}; | ||
function<T()> _mainFunc = [](){}; | ||
T _result; | ||
|
||
public: | ||
CallBack(function<T()> func){ | ||
_mainFunc = func; | ||
}; | ||
|
||
~CallBack() { | ||
//printf("CallBack::~CallBack p [%p]\n",this); | ||
}; | ||
|
||
void then(function<void()> onThen){ | ||
_onThen = onThen; | ||
}; | ||
|
||
T getResult(){ | ||
return _result; | ||
} | ||
|
||
void run(){ | ||
_result = _mainFunc(); | ||
_onThen(); | ||
}; | ||
}; | ||
|
||
template<> | ||
class CallBack<void> { | ||
|
||
private: | ||
function<void()> _onThen = [](){}; | ||
function<void()> _mainFunc = [](){}; | ||
|
||
public: | ||
CallBack(function<void()> func){ | ||
_mainFunc = func; | ||
}; | ||
|
||
~CallBack() { | ||
//printf("CallBack::~CallBack p [%p]\n",this); | ||
}; | ||
|
||
void then(function<void()> onThen){ | ||
_onThen = onThen; | ||
}; | ||
|
||
void run(){ | ||
_mainFunc(); | ||
_onThen(); | ||
}; | ||
}; | ||
|
||
}} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -15,6 +15,7 @@ | |
#include <string> | ||
#include <vector> | ||
#include <map> | ||
#include <memory> | ||
|
||
#if defined(WANT_XERCES) | ||
|
||
|
@@ -23,10 +24,12 @@ | |
#endif | ||
|
||
#include "rapidxml/rapidxml.hpp" | ||
#include "callback.h" | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. you forgot to include memory |
||
#include "data_types.h" | ||
#include "leak_dumper.h" | ||
|
||
using namespace rapidxml; | ||
using namespace Shared::Util; | ||
using namespace std; | ||
|
||
#if defined(WANT_XERCES) | ||
|
@@ -151,6 +154,7 @@ class XmlTree{ | |
void setSkipUpdatePathClimbingParts(bool value); | ||
void init(const string &name); | ||
void load(const string &path, const std::map<string,string> &mapTagReplacementValues, bool noValidation=false,bool skipStackCheck=false,bool skipStackTrace=false); | ||
std::shared_ptr<CallBack<void>> loadAsync(const string &path, const std::map<string,string> &mapTagReplacementValues, bool noValidation=false,bool skipStackCheck=false,bool skipStackTrace=false); | ||
void save(const string &path); | ||
|
||
XmlNode *getRootNode() const {return rootNode;} | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is done in other places of the code with https://github.com/MegaGlest/megaglest-source/blob/develop/source/shared_lib/include/platform/common/simple_threads.h#L71
Although honestly your way seems cleaner to me.