Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump json5 and babel-loader in /tests/frontend/e2e #644

Open
wants to merge 4 commits into
base: development
Choose a base branch
from

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Jan 3, 2023

Bumps json5 to 2.2.3 and updates ancestor dependency babel-loader. These dependencies need to be updated together.

Updates json5 from 2.1.3 to 2.2.3

Release notes

Sourced from json5's releases.

v2.2.3

v2.2.2

  • Fix: Properties with the name __proto__ are added to objects and arrays. (#199) This also fixes a prototype pollution vulnerability reported by Jonathan Gregson! (#295).

v2.2.1

v2.2.0

  • New: Accurate and documented TypeScript declarations are now included. There is no need to install @types/json5. (#236, #244)
Changelog

Sourced from json5's changelog.

v2.2.3 [code, diff]

v2.2.2 [code, diff]

  • Fix: Properties with the name __proto__ are added to objects and arrays. (#199) This also fixes a prototype pollution vulnerability reported by Jonathan Gregson! (#295).

v2.2.1 [code, diff]

v2.2.0 [code, diff]

  • New: Accurate and documented TypeScript declarations are now included. There is no need to install @types/json5. (#236, #244)
Commits
  • c3a7524 2.2.3
  • 94fd06d docs: update CHANGELOG for v2.2.3
  • 3b8cebf docs(security): use GitHub security advisories
  • f0fd9e1 docs: publish a security policy
  • 6a91a05 docs(template): bug -> bug report
  • 14f8cb1 2.2.2
  • 10cc7ca docs: update CHANGELOG for v2.2.2
  • 7774c10 fix: add proto to objects and arrays
  • edde30a Readme: slight tweak to intro
  • 97286f8 Improve example in readme
  • Additional commits viewable in compare view

Updates babel-loader from 8.2.1 to 8.3.0

Release notes

Sourced from babel-loader's releases.

v8.3.0

New features

Full Changelog: babel/babel-loader@v8.2.5...v8.3.0

v8.2.5

What's Changed

New Contributors

Full Changelog: babel/babel-loader@v8.2.4...v8.2.5

v8.2.4

What's Changed

Thanks @​loveDstyle, @​stianjensen and @​pathmapper for your first PRs!

8.2.3

This release fixes compatibility with Node.js 17

Thanks @​Reptarsrage!

Commits

You can trigger a rebase of this PR by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
  • @dependabot use these labels will set the current labels as the default for future PRs for this repo and language
  • @dependabot use these reviewers will set the current reviewers as the default for future PRs for this repo and language
  • @dependabot use these assignees will set the current assignees as the default for future PRs for this repo and language
  • @dependabot use this milestone will set the current milestone as the default for future PRs for this repo and language

You can disable automated security fix PRs for this repo from the Security Alerts page.

Note
Automatic rebases have been disabled on this pull request as it has been open for over 30 days.

Bumps [json5](https://github.com/json5/json5) to 2.2.3 and updates ancestor dependency [babel-loader](https://github.com/babel/babel-loader). These dependencies need to be updated together.


Updates `json5` from 2.1.3 to 2.2.3
- [Release notes](https://github.com/json5/json5/releases)
- [Changelog](https://github.com/json5/json5/blob/main/CHANGELOG.md)
- [Commits](json5/json5@v2.1.3...v2.2.3)

Updates `babel-loader` from 8.2.1 to 8.3.0
- [Release notes](https://github.com/babel/babel-loader/releases)
- [Changelog](https://github.com/babel/babel-loader/blob/main/CHANGELOG.md)
- [Commits](babel/babel-loader@v8.2.1...v8.3.0)

---
updated-dependencies:
- dependency-name: json5
  dependency-type: indirect
- dependency-name: babel-loader
  dependency-type: direct:development
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot added dependencies Pull requests that update a dependency file javascript Pull requests that update Javascript code labels Jan 3, 2023
@ddelpiano ddelpiano marked this pull request as draft January 5, 2023 14:39
@ddelpiano ddelpiano marked this pull request as ready for review February 1, 2023 17:53
@ddelpiano ddelpiano changed the base branch from master to development February 1, 2023 17:54
@ddelpiano
Copy link
Member

@SimaoBolota-MetaCell could you review this and approve the pr if you are ok with the change? thx

@ddelpiano
Copy link
Member

@SimaoBolota-MetaCell could you have a look at these conflicts please? Thx

@SimaoBolota-MetaCell SimaoBolota-MetaCell force-pushed the dependabot/npm_and_yarn/tests/frontend/e2e/json5-and-babel-loader-2.2.3 branch from 3430898 to 4b2ad31 Compare February 15, 2023 14:43
SimaoBolota-MetaCell and others added 3 commits February 17, 2023 12:07
This reverts commit 3155805.
…endabot/npm_and_yarn/tests/frontend/e2e/json5-and-babel-loader-2.2.3
@filippomc
Copy link
Contributor

Beware of an error in the build:

[4/4] Building fresh packages...
[-/9] ⠐ waiting...
[-/9] ⠐ waiting...
[3/9] ⠐ node-sass
[-/9] ⠐ waiting...
error /home/user/NetPyNE-UI/webapp/node_modules/node-sass: Command failed.
Exit code: 1
Command: node scripts/build.js
Arguments: 
Directory: /home/user/NetPyNE-UI/webapp/node_modules/node-sass
Output:
Building: /usr/local/bin/node /home/user/NetPyNE-UI/webapp/node_modules/node-gyp/bin/node-gyp.js rebuild --verbose --libsass_ext= --libsass_cflags= --libsass_ldflags= --libsass_library=
gyp info it worked if it ends with ok
gyp verb cli [
gyp verb cli   '/usr/local/bin/node',
gyp verb cli   '/home/user/NetPyNE-UI/webapp/node_modules/node-gyp/bin/node-gyp.js',
gyp verb cli   'rebuild',
gyp verb cli   '--verbose',
gyp verb cli   '--libsass_ext=',
gyp verb cli   '--libsass_cflags=',
gyp verb cli   '--libsass_ldflags=',
gyp verb cli   '--libsass_library='
gyp verb cli ]
gyp info using [email protected]
gyp info using [email protected] | linux | x64
gyp verb command rebuild []
gyp verb command clean []
gyp verb clean removing "build" directory
gyp verb command configure []
gyp verb check python checking for Python executable "python2" in the PATH
gyp verb `which` succeeded python2 /usr/bin/python2
gyp verb check python version `/usr/bin/python2 -c "import sys; print "2.7.18
gyp verb check python version .%s.%s" % sys.version_info[:3];"` returned: %j
gyp verb get node dir no --target version specified, falling back to host node version: 19.6.0
gyp verb command install [ '19.6.0' ]
gyp verb install input version string "19.6.0"
gyp verb install installing version: 19.6.0
gyp verb install --ensure was passed, so won't reinstall if already installed
gyp verb install version is already installed, need to check "installVersion"
gyp verb got "installVersion" 9
gyp verb needs "installVersion" 9
gyp verb install version is good
gyp verb get node dir target node version installed: 19.6.0
gyp verb build dir attempting to create "build" dir: /home/user/NetPyNE-UI/webapp/node_modules/node-sass/build
gyp verb build dir "build" dir needed to be created? /home/user/NetPyNE-UI/webapp/node_modules/node-sass/build
gyp verb build/config.gypi creating config file
gyp verb build/config.gypi writing out config file: /home/user/NetPyNE-UI/webapp/node_modules/node-sass/build/config.gypi
gyp verb config.gypi checking for gypi file: /home/user/NetPyNE-UI/webapp/node_modules/node-sass/config.gypi
gyp verb common.gypi checking for gypi file: /home/user/NetPyNE-UI/webapp/node_modules/node-sass/common.gypi
gyp verb gyp gyp format was not specified; forcing "make"
gyp info spawn /usr/bin/python2
gyp info spawn args [
gyp info spawn args   '/home/user/NetPyNE-UI/webapp/node_modules/node-gyp/gyp/gyp_main.py',
gyp info spawn args   'binding.gyp',
gyp info spawn args   '-f',
gyp info spawn args   'make',
gyp info spawn args   '-I',
gyp info spawn args   '/home/user/NetPyNE-UI/webapp/node_modules/node-sass/build/config.gypi',
gyp info spawn args   '-I',
gyp info spawn args   '/home/user/NetPyNE-UI/webapp/node_modules/node-gyp/addon.gypi',
gyp info spawn args   '-I',
gyp info spawn args   '/home/user/.node-gyp/19.6.0/include/node/common.gypi',
gyp info spawn args   '-Dlibrary=shared_library',
gyp info spawn args   '-Dvisibility=default',
gyp info spawn args   '-Dnode_root_dir=/home/user/.node-gyp/19.6.0',
gyp info spawn args   '-Dnode_gyp_dir=/home/user/NetPyNE-UI/webapp/node_modules/node-gyp',
gyp info spawn args   '-Dnode_lib_file=/home/user/.node-gyp/19.6.0/<(target_arch)/node.lib',
gyp info spawn args   '-Dmodule_root_dir=/home/user/NetPyNE-UI/webapp/node_modules/node-sass',
gyp info spawn args   '-Dnode_engine=v8',
gyp info spawn args   '--depth=.',
gyp info spawn args   '--no-parallel',
gyp info spawn args   '--generator-output',
gyp info spawn args   'build',
gyp info spawn args   '-Goutput_dir=.'
gyp info spawn args ]
gyp: Undefined variable standalone_static_library in binding.gyp while trying to load binding.gyp
gyp ERR! configure error 
gyp ERR! stack Error: `gyp` failed with exit code: 1
gyp ERR! stack     at ChildProcess.onCpExit (/home/user/NetPyNE-UI/webapp/node_modules/node-gyp/lib/configure.js:345:16)
gyp ERR! stack     at ChildProcess.emit (node:events:512:28)
gyp ERR! stack     at ChildProcess._handle.onexit (node:internal/child_process:293:12)
gyp ERR! System Linux 5.15.90.1-microsoft-standard-WSL2
gyp ERR! command "/usr/local/bin/node" "/home/user/NetPyNE-UI/webapp/node_modules/node-gyp/bin/node-gyp.js" "rebuild" "--verbose" "--libsass_ext=" "--libsass_cflags=" "--libsass_ldflags=" "--libsass_library="
gyp ERR! cwd /home/user/NetPyNE-UI/webapp/node_modules/node-sass
gyp ERR! node -v v19.6.0

@enicolasgomez @ddelpiano

@ddelpiano ddelpiano marked this pull request as draft January 24, 2024 11:29
@ddelpiano ddelpiano marked this pull request as ready for review July 10, 2024 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file javascript Pull requests that update Javascript code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants