Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added SIP that reproduces the checksum algorithm #124

Merged
merged 7 commits into from
Nov 30, 2023
Merged

Added SIP that reproduces the checksum algorithm #124

merged 7 commits into from
Nov 30, 2023

Conversation

ritave
Copy link
Contributor

@ritave ritave commented Nov 28, 2023 •
edited
Loading

This SIP describes an algorithm used to checksum a snap in a reproducible manner in a way that includes all files required to run the snap.

fixes #123

@socket-security Socket Security
Copy link

socket-security bot commented Nov 28, 2023 •
edited
Loading

New dependencies detected. Learn more about Socket for GitHub ↗︎

Packages Version New capabilities Transitives Size Publisher
@metamask/utils 8.2.1 filesystem +18 5.07 MB metamaskbot
fast-json-stable-stringify 2.1.0 None +0 17 kB esp
@types/node 20.10.1 None +1 4 MB types
@scure/base 1.1.3 None +0 77.8 kB paulmillr
@noble/hashes 1.3.2 None +0 747 kB paulmillr
typescript 5.3.2 None +0 32 MB typescript-bot

@socket-security Socket Security
Copy link

socket-security bot commented Nov 28, 2023 •
edited
Loading

👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

@ritave ritave marked this pull request as ready for review November 29, 2023 13:15
@ritave ritave requested review from Montoya, ziad-saab and a team as code owners November 29, 2023 13:15
FrederikBolding
FrederikBolding requested changes Nov 29, 2023
View reviewed changes
SIPS/sip-124.md Outdated Show resolved Hide resolved
assets/sip-124/implementation/package.json Outdated Show resolved Hide resolved
assets/sip-124/implementation/tsconfig.json Outdated Show resolved Hide resolved
assets/sip-124/implementation/implementation.ts Outdated Show resolved Hide resolved
assets/sip-124/implementation/implementation.ts Outdated Show resolved Hide resolved
hmalik88
hmalik88 reviewed Nov 29, 2023
View reviewed changes
SIPS/sip-124.md Outdated Show resolved Hide resolved
hmalik88
hmalik88 reviewed Nov 29, 2023
View reviewed changes
SIPS/sip-124.md Outdated Show resolved Hide resolved
hmalik88
hmalik88 reviewed Nov 29, 2023
View reviewed changes
SIPS/sip-124.md Outdated Show resolved Hide resolved
hmalik88
hmalik88 reviewed Nov 29, 2023
View reviewed changes
SIPS/sip-124.md Outdated Show resolved Hide resolved
FrederikBolding
FrederikBolding reviewed Nov 30, 2023
View reviewed changes
SIPS/sip-124.md Outdated Show resolved Hide resolved
@ritave
Code review 2
be6a538 
* Renamed SIP to latest free SIP from all PRs
* Fix bullet points
* Removed TODOs
hmalik88
hmalik88 approved these changes Nov 30, 2023
View reviewed changes
Copy link
Contributor

@hmalik88 hmalik88 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ritave ritave merged commit c58cc81 into main Nov 30, 2023
3 checks passed
@ritave ritave deleted the ritave/checksum branch November 30, 2023 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hmalik88 hmalik88 hmalik88 approved these changes

@FrederikBolding FrederikBolding FrederikBolding approved these changes

@Montoya Montoya Awaiting requested review from Montoya Montoya is a code owner

@ziad-saab ziad-saab Awaiting requested review from ziad-saab

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

SIP for multi-file checksum algorithm
3 participants
@ritave @FrederikBolding @hmalik88