Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SIP-26: Update Snaps-specific parts of the specification #153

Merged
merged 4 commits into from
Nov 14, 2024

Conversation

FrederikBolding
Copy link
Member

Makes a couple of updates to SIP-26 to add some details for permission specifications, the required Snap export and account resolution.

Verified

This commit was signed with the committer’s verified signature.
FrederikBolding Frederik Bolding
@FrederikBolding FrederikBolding requested review from Montoya and a team as code owners November 13, 2024 14:14

Verified

This commit was signed with the committer’s verified signature.
FrederikBolding Frederik Bolding

Verified

This commit was signed with the committer’s verified signature.
FrederikBolding Frederik Bolding
SIPS/sip-26.md Outdated Show resolved Hide resolved

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
Co-authored-by: Alex Donesky <[email protected]>
@FrederikBolding FrederikBolding merged commit 739f165 into dr/accounts Nov 14, 2024
3 checks passed
@FrederikBolding FrederikBolding deleted the fb/sip-26-additions branch November 14, 2024 12:23
FrederikBolding added a commit that referenced this pull request Nov 14, 2024

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
* Add draft of SIP-26

* Remove optional header fields

* Add SIP number and remove unused optional fields

* Rename diagram image

* Rename components diagram in document

* Update diagram and add components descriptions

* Rename "Address Resolution Snaps" to "Account Address Resolution Snaps"

* Update components diagram

* Update `resolveAccountAddress` signature

* Add link to CAIP-2 and remove commented text

* Add Protocol Snaps

* Update components diagram

* Update `resolveAccountAddress` docs

* Clarify: should -> MUST

* Update `resolveAccountAddress` method

* Remove mention to SIP-25

* Add note about Snap events

* Minor text improvements

* Add mention to CAIP-2 chain IDs

Co-authored-by: Gustavo Antunes <[email protected]>

* Update keyring-api repo URL

Co-authored-by: Charly Chevalier <[email protected]>

* Add note about Accounts Router and Protocol Snaps priority

* chore: update SIP-26 following latest discussions

* SIP-26: Update Snaps-specific parts of the specification (#153)

* SIP-26: Update Snaps-specific parts of the specification

* Minor updates

* Reword slightly

* Update SIPS/sip-26.md

Co-authored-by: Alex Donesky <[email protected]>

---------

Co-authored-by: Alex Donesky <[email protected]>

* chore: update title

Co-authored-by: Frederik Bolding <[email protected]>

* Apply suggestions from code review

Co-authored-by: Alex Donesky <[email protected]>

* Update SIPS/sip-26.md

---------

Co-authored-by: Gustavo Antunes <[email protected]>
Co-authored-by: Charly Chevalier <[email protected]>
Co-authored-by: Frederik Bolding <[email protected]>
Co-authored-by: Alex Donesky <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants