generated from MetaMask/metamask-module-template
-
-
Notifications
You must be signed in to change notification settings - Fork 4
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
- Loading branch information
1 parent
7525e99
commit 374efa6
Showing
13 changed files
with
707 additions
and
7 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,89 @@ | ||
# Changelog | ||
|
||
All notable changes to this project will be documented in this file. | ||
|
||
The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/), | ||
and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html). | ||
|
||
## [Unreleased] | ||
|
||
## [6.0.4] | ||
|
||
### Changed | ||
|
||
- Bump `@metamask/*` and `@lavamoat/*` dependencies ([#46](https://github.com/MetaMask/accounts/pull/46)) | ||
- Move `deepmerge` to `devDependencies` ([#44](https://github.com/MetaMask/accounts/pull/44)) | ||
|
||
## [6.0.3] | ||
|
||
### Changed | ||
|
||
- Convert to monorepo | ||
- Package name does not change (`@metamask/eth-simple-keyring`) and sources have been moved to: `packages/keyring-eth-simple`. | ||
- You can find all the changes [here](https://github.com/MetaMask/accounts/compare/6da58b4...38794aa). | ||
|
||
## [6.0.2] | ||
|
||
### Changed | ||
|
||
- Bump `@metamask/utils` from `^8.1.0` to `^9.0.0` ([#177](https://github.com/MetaMask/eth-simple-keyring/pull/177)) | ||
|
||
## [6.0.1] | ||
|
||
### Fixed | ||
|
||
- Treat `undefined` and `null` as empty array in deserialize function ([#163](https://github.com/MetaMask/eth-simple-keyring/pull/163)) | ||
|
||
## [6.0.0] | ||
|
||
### Changed | ||
|
||
- **BREAKING**: Increase minimum Node.js version to 16 ([#152](https://github.com/MetaMask/eth-simple-keyring/pull/152)) | ||
- **BREAKING**: Bump @metamask/eth-sig-util from ^6.0.1 to ^7.0.0 ([#156](https://github.com/MetaMask/eth-simple-keyring/pull/156)) | ||
- Bump @metamask/utils from ^5.0.0 to ^8.1.0 ([#153](https://github.com/MetaMask/eth-simple-keyring/pull/153)) | ||
- Bump ethereum-cryptography from ^1.2.0 to ^2.1.2 ([#153](https://github.com/MetaMask/eth-simple-keyring/pull/153)) | ||
|
||
## [5.1.1] | ||
|
||
### Fixed | ||
|
||
- Treat `undefined` and `null` as empty array in deserialize function ([#166](https://github.com/MetaMask/eth-simple-keyring/pull/166)) | ||
|
||
## [5.1.0] | ||
|
||
### Changed | ||
|
||
- Export TypeScript interfaces ([#140](https://github.com/MetaMask/eth-simple-keyring/pull/140)) | ||
- Update all dependencies ([#140](https://github.com/MetaMask/eth-simple-keyring/pull/140)) ([#149](https://github.com/MetaMask/eth-simple-keyring/pull/149)) | ||
|
||
### Fixed | ||
|
||
- Add `validateMessage` option to `signMessage` to configure if runtime-validation should be done that input string is hex (default: `true`) ([#148](https://github.com/MetaMask/eth-simple-keyring/pull/148)) | ||
|
||
## [5.0.0] | ||
|
||
### Changed | ||
|
||
- **BREAKING:** Makes version-specific `signTypedData` methods private ([#84](https://github.com/MetaMask/eth-simple-keyring/pull/84)) | ||
- Consumers should use the generic `signTypedData` method and pass the version they'd like as a property in the options argument. | ||
- **BREAKING:** Makes the `wallets` property private ([#87](https://github.com/MetaMask/eth-simple-keyring/pull/87)) | ||
- Consumers should not use this property as it is intended for internal use only. | ||
- **BREAKING:** Makes `getPrivateKeyFor` a private method ([#83](https://github.com/MetaMask/eth-simple-keyring/pull/83)) | ||
- Consumers who wish to get the private key for a given account should use the `exportAccount` method. | ||
- **BREAKING:** Set the minimum Node.js version to 14 ([#68](https://github.com/MetaMask/eth-simple-keyring/pull/68)) ([#109](https://github.com/MetaMask/eth-simple-keyring/pull/109)) | ||
- Always return rejected Promise upon failure ([#85](https://github.com/MetaMask/eth-simple-keyring/pull/85)) | ||
|
||
### Removed | ||
|
||
- **BREAKING:** Remove redundant `newGethSignMessage` method ([#72](https://github.com/MetaMask/eth-simple-keyring/pull/72)) | ||
- Consumers can use `signPersonalMessage` method as a replacement for `newGethSignMessage`. | ||
|
||
[Unreleased]: https://github.com/MetaMask/accounts/compare/@metamask/[email protected] | ||
[6.0.4]: https://github.com/MetaMask/accounts/compare/@metamask/[email protected]...@metamask/[email protected] | ||
[6.0.3]: https://github.com/MetaMask/accounts/compare/@metamask/[email protected]...@metamask/[email protected] | ||
[6.0.2]: https://github.com/MetaMask/accounts/compare/@metamask/[email protected]...@metamask/[email protected] | ||
[6.0.1]: https://github.com/MetaMask/accounts/compare/@metamask/[email protected]...@metamask/[email protected] | ||
[6.0.0]: https://github.com/MetaMask/accounts/compare/@metamask/[email protected]...@metamask/[email protected] | ||
[5.1.1]: https://github.com/MetaMask/accounts/compare/@metamask/[email protected]...@metamask/[email protected] | ||
[5.1.0]: https://github.com/MetaMask/accounts/compare/@metamask/[email protected]...@metamask/[email protected] | ||
[5.0.0]: https://github.com/MetaMask/accounts/releases/tag/@metamask/[email protected] |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,15 @@ | ||
ISC License | ||
|
||
Copyright (c) 2020 MetaMask | ||
|
||
Permission to use, copy, modify, and/or distribute this software for any | ||
purpose with or without fee is hereby granted, provided that the above | ||
copyright notice and this permission notice appear in all copies. | ||
|
||
THE SOFTWARE IS PROVIDED "AS IS" AND THE AUTHOR DISCLAIMS ALL WARRANTIES | ||
WITH REGARD TO THIS SOFTWARE INCLUDING ALL IMPLIED WARRANTIES OF | ||
MERCHANTABILITY AND FITNESS. IN NO EVENT SHALL THE AUTHOR BE LIABLE FOR | ||
ANY SPECIAL, DIRECT, INDIRECT, OR CONSEQUENTIAL DAMAGES OR ANY DAMAGES | ||
WHATSOEVER RESULTING FROM LOSS OF USE, DATA OR PROFITS, WHETHER IN AN | ||
ACTION OF CONTRACT, NEGLIGENCE OR OTHER TORTIOUS ACTION, ARISING OUT OF | ||
OR IN CONNECTION WITH THE USE OR PERFORMANCE OF THIS SOFTWARE. |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,133 @@ | ||
# Simple Keyring | ||
|
||
A simple JS class wrapped around [ethereumjs-wallet](https://github.com/ethereumjs/ethereumjs-wallet) designed to expose an interface common to many different signing strategies to be used in a `KeyringController`; such as the one used in [MetaMask](https://metamask.io/) | ||
|
||
## The Keyring Class Protocol | ||
|
||
One of the goals of this class is to allow developers to easily add new signing strategies to MetaMask. We call these signing strategies Keyrings, because they can manage multiple keys. | ||
|
||
### Keyring.type | ||
|
||
A class property that returns a unique string describing the Keyring. | ||
This is the only class property or method, the remaining methods are instance methods. | ||
|
||
### constructor( options ) | ||
|
||
As a Javascript class, your Keyring object will be used to instantiate new Keyring instances using the new keyword. For example: | ||
|
||
``` | ||
const keyring = new YourKeyringClass(options); | ||
``` | ||
|
||
The constructor currently receives an options object that will be defined by your keyring-building UI, once the user has gone through the steps required for you to fully instantiate a new keyring. For example, choosing a pattern for a vanity account, or entering a seed phrase. | ||
|
||
We haven't defined the protocol for this account-generating UI yet, so for now please ensure your Keyring behaves nicely when not passed any options object. | ||
|
||
## Keyring Instance Methods | ||
|
||
All below instance methods must return Promises to allow asynchronous resolution. | ||
|
||
### serialize() | ||
|
||
In this method, you must return any JSON-serializable JavaScript object that you like. It will be encoded to a string, encrypted with the user's password, and stored to disk. This is the same object you will receive in the deserialize() method, so it should capture all the information you need to restore the Keyring's state. | ||
|
||
### deserialize( object ) | ||
|
||
As discussed above, the deserialize() method will be passed the JavaScript object that you returned when the serialize() method was called. | ||
|
||
### addAccounts( n = 1 ) | ||
|
||
The addAccounts(n) method is used to inform your keyring that the user wishes to create a new account. You should perform whatever internal steps are needed so that a call to serialize() will persist the new account, and then return an array of the new account addresses. | ||
|
||
The method may be called with or without an argument, specifying the number of accounts to create. You should generally default to 1 per call. | ||
|
||
### getAccounts() | ||
|
||
When this method is called, you must return an array of hex-string addresses for the accounts that your Keyring is able to sign for. | ||
|
||
### signTransaction(address, transaction) | ||
|
||
This method will receive a hex-prefixed, all-lowercase address string for the account you should sign the incoming transaction with. | ||
|
||
For your convenience, the transaction is an instance of ethereumjs-tx, (https://github.com/ethereumjs/ethereumjs-tx) so signing can be as simple as: | ||
|
||
``` | ||
transaction.sign(privateKey) | ||
``` | ||
|
||
You must return a valid signed ethereumjs-tx (https://github.com/ethereumjs/ethereumjs-tx) object when complete, it can be the same transaction you received. | ||
|
||
### signMessage(address, data) | ||
|
||
The `eth_sign` method will receive the incoming data, already hashed, and must sign that hash, and then return the raw signed hash. | ||
|
||
### getEncryptionPublicKey(address) | ||
|
||
This provides the public key for encryption function. | ||
|
||
### decryptMessage(address, data) | ||
|
||
The `eth_decryptMessage` method will receive the incoming data in array format that returns `encrypt` function in `eth-sig-util` and must decrypt message, and then return the raw message. | ||
|
||
### exportAccount(address) | ||
|
||
Exports the specified account as a private key hex string. | ||
|
||
### removeAccount(address) | ||
|
||
removes the specified account from the list of accounts. | ||
|
||
## Contributing | ||
|
||
### Setup | ||
|
||
- Install [Node.js](https://nodejs.org) version 16 or greater | ||
- If you are using [nvm](https://github.com/creationix/nvm#installation) (recommended) running `nvm use` will automatically choose the right node version for you. | ||
- Install [Yarn v3](https://yarnpkg.com/getting-started/install) | ||
- Run `yarn install` to install dependencies and run any required post-install scripts | ||
|
||
-- This package implicitly relies on Buffer to be present (meaning that if someone wants to use this in a browser context, they need to supply a polyfill for Buffer or use the `buffer` package) | ||
|
||
### Testing and Linting | ||
|
||
Run `yarn test` to run the tests once. To run tests on file changes, run `yarn test:watch`. | ||
|
||
Run `yarn lint` to run the linter, or run `yarn lint:fix` to run the linter and fix any automatically fixable issues. | ||
|
||
### Release & Publishing | ||
|
||
The project follows the same release process as the other libraries in the MetaMask organization. The GitHub Actions [`action-create-release-pr`](https://github.com/MetaMask/action-create-release-pr) and [`action-publish-release`](https://github.com/MetaMask/action-publish-release) are used to automate the release process; see those repositories for more information about how they work. | ||
|
||
1. Choose a release version. | ||
|
||
- The release version should be chosen according to SemVer. Analyze the changes to see whether they include any breaking changes, new features, or deprecations, then choose the appropriate SemVer version. See [the SemVer specification](https://semver.org/) for more information. | ||
|
||
2. If this release is backporting changes onto a previous release, then ensure there is a major version branch for that version (e.g. `1.x` for a `v1` backport release). | ||
|
||
- The major version branch should be set to the most recent release with that major version. For example, when backporting a `v1.0.2` release, you'd want to ensure there was a `1.x` branch that was set to the `v1.0.1` tag. | ||
|
||
3. Trigger the [`workflow_dispatch`](https://docs.github.com/en/actions/reference/events-that-trigger-workflows#workflow_dispatch) event [manually](https://docs.github.com/en/actions/managing-workflow-runs/manually-running-a-workflow) for the `Create Release Pull Request` action to create the release PR. | ||
|
||
- For a backport release, the base branch should be the major version branch that you ensured existed in step 2. For a normal release, the base branch should be the main branch for that repository (which should be the default value). | ||
- This should trigger the [`action-create-release-pr`](https://github.com/MetaMask/action-create-release-pr) workflow to create the release PR. | ||
|
||
4. Update the changelog to move each change entry into the appropriate change category ([See here](https://keepachangelog.com/en/1.0.0/#types) for the full list of change categories, and the correct ordering), and edit them to be more easily understood by users of the package. | ||
|
||
- Generally any changes that don't affect consumers of the package (e.g. lockfile changes or development environment changes) are omitted. Exceptions may be made for changes that might be of interest despite not having an effect upon the published package (e.g. major test improvements, security improvements, improved documentation, etc.). | ||
- Try to explain each change in terms that users of the package would understand (e.g. avoid referencing internal variables/concepts). | ||
- Consolidate related changes into one change entry if it makes it easier to explain. | ||
- Run `yarn auto-changelog validate --rc` to check that the changelog is correctly formatted. | ||
|
||
5. Review and QA the release. | ||
|
||
- If changes are made to the base branch, the release branch will need to be updated with these changes and review/QA will need to restart again. As such, it's probably best to avoid merging other PRs into the base branch while review is underway. | ||
|
||
6. Squash & Merge the release. | ||
|
||
- This should trigger the [`action-publish-release`](https://github.com/MetaMask/action-publish-release) workflow to tag the final release commit and publish the release on GitHub. | ||
|
||
7. Publish the release on npm. | ||
|
||
- Be very careful to use a clean local environment to publish the release, and follow exactly the same steps used during CI. | ||
- Use `npm publish --dry-run` to examine the release contents to ensure the correct files are included. Compare to previous releases if necessary (e.g. using `https://unpkg.com/browse/[package name]@[package version]/`). | ||
- Once you are confident the release contents are correct, publish the release using `npm publish`. |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,29 @@ | ||
/* | ||
* For a detailed explanation regarding each configuration property and type check, visit: | ||
* https://jestjs.io/docs/configuration | ||
*/ | ||
|
||
const merge = require('deepmerge'); | ||
const path = require('path'); | ||
|
||
const baseConfig = require('../../jest.config.packages'); | ||
|
||
const displayName = path.basename(__dirname); | ||
|
||
module.exports = merge(baseConfig, { | ||
// The display name when running multiple projects | ||
displayName, | ||
|
||
// An array of regexp pattern strings used to skip coverage collection | ||
coveragePathIgnorePatterns: ['./src/tests'], | ||
|
||
// An object that configures minimum threshold enforcement for coverage results | ||
coverageThreshold: { | ||
global: { | ||
branches: 100, | ||
functions: 100, | ||
lines: 100, | ||
statements: 100, | ||
}, | ||
}, | ||
}); |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,76 @@ | ||
{ | ||
"name": "@metamask/eth-qr-keyring", | ||
"version": "1.0.0", | ||
"description": "A simple standard interface for a series of Ethereum private keys.", | ||
"keywords": [ | ||
"ethereum", | ||
"keyring", | ||
"qr", | ||
"metamask" | ||
], | ||
"homepage": "https://github.com/MetaMask/accounts/packages/keyring-eth-qr#readme", | ||
"bugs": { | ||
"url": "https://github.com/MetaMask/accounts/issues" | ||
}, | ||
"repository": { | ||
"type": "git", | ||
"url": "https://github.com/MetaMask/accounts.git" | ||
}, | ||
"main": "dist/index.js", | ||
"types": "dist/index.d.ts", | ||
"files": [ | ||
"dist/" | ||
], | ||
"scripts": { | ||
"build": "tsc --build tsconfig.build.json", | ||
"build:clean": "rimraf dist && yarn build", | ||
"build:docs": "typedoc", | ||
"build:force": "tsc --build tsconfig.build.json --force", | ||
"changelog:update": "../../scripts/update-changelog.sh @metamask/eth-simple-keyring", | ||
"changelog:validate": "../../scripts/validate-changelog.sh @metamask/eth-simple-keyring", | ||
"publish:preview": "yarn npm publish --tag preview", | ||
"sample": "ts-node src/sample.ts", | ||
"test": "jest", | ||
"test:clean": "jest --clearCache", | ||
"test:verbose": "jest --verbose", | ||
"test:watch": "jest --watch" | ||
}, | ||
"dependencies": { | ||
"@ethereumjs/util": "^9.1.0", | ||
"@keystonehq/bc-ur-registry-eth": "^0.21.0", | ||
"@keystonehq/ur-decoder": "^0.12.2", | ||
"@metamask/utils": "^9.2.1", | ||
"@ngraveio/bc-ur": "^1.1.13", | ||
"hdkey": "^2.1.0" | ||
}, | ||
"devDependencies": { | ||
"@lavamoat/allow-scripts": "^3.2.1", | ||
"@metamask/auto-changelog": "^3.4.4", | ||
"@types/hdkey": "^2.0.1", | ||
"@types/jest": "^29.5.12", | ||
"@types/node": "^20.12.12", | ||
"deepmerge": "^4.2.2", | ||
"depcheck": "^1.4.7", | ||
"jest": "^29.5.0", | ||
"ts-jest": "^29.0.5", | ||
"ts-node": "^10.9.2", | ||
"typedoc": "^0.25.13", | ||
"typescript": "~4.8.4" | ||
}, | ||
"engines": { | ||
"node": "^18.18 || >=20" | ||
}, | ||
"publishConfig": { | ||
"access": "public", | ||
"registry": "https://registry.npmjs.org/" | ||
}, | ||
"lavamoat": { | ||
"allowScripts": { | ||
"keccak": true, | ||
"secp256k1": true, | ||
"@lavamoat/preinstall-always-fail": false, | ||
"ethereumjs-tx>ethereumjs-util>ethereum-cryptography>keccak": false, | ||
"ethereumjs-tx>ethereumjs-util>ethereum-cryptography>secp256k1": false | ||
} | ||
} | ||
} |
Oops, something went wrong.