refactor: move deps to devDeps for types + use peerDep for keyring-api #131
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@metamaskbot publish-preview |
|
Preview builds have been published. See these instructions (from the Expand for full list of packages and versions. |
ccharly
force-pushed
the
refactor/deps
branch
from
4685a87 to
1a4d499
Compare
ccharly
commented
Dec 10, 2024
| "typedoc": "^0.25.13", | ||
| "typescript": "~5.6.3" | ||
| }, | ||
| "peerDependencies": { | ||
| "tslib": "^2.6.2" |
There was a problem hiding this comment.
This should have been a peerDependencies since the introduction of @trezor/connect-web.
ccharly
force-pushed
the
refactor/deps
branch
2 times, most recently
from
a0d508c to
8e5037c
Compare
ccharly
force-pushed
the
refactor/deps
branch
from
8e5037c to
fb72e65
Compare
|
@metamaskbot publish-preview |
|
Preview builds have been published. See these instructions (from the Expand for full list of packages and versions. |
ccharly
commented
Dec 10, 2024
| @@ -61,7 +61,8 @@ | |||
| "@ts-bridge/cli": "^0.6.1", | |||
| "@types/jest": "^29.5.12", | |||
| "deepmerge": "^4.2.2", | |||
| "jest": "^29.5.0" | |||
| "jest": "^29.5.0", | |||
| "typescript": "~5.6.3" | |||
There was a problem hiding this comment.
Not needed as of now, but since this package has already been "future-proof" for ts-bridge we might wanna add typescript as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updating some deps to avoid pulling non-needed dependencies in the main dependency tree.
Also, use
@metamask/keyring-apias apeerDependenciesfor every packages to force using the same API everywhere.