Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add export tests for profile-sync-controller #5017

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

mcmire
Copy link
Contributor

@mcmire mcmire commented Dec 3, 2024

Explanation

I found it difficult to review changes to @metamask/profile-sync-controller as it was not completely clear to me what this package exported.

For other packages we have begun using unit tests for index.ts files to make exports more visible. This commit adds such tests.

References

(None)

Changelog

(N/A)

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
  • I've highlighted breaking changes using the "BREAKING" category above as appropriate
  • I've prepared draft pull requests for clients and consumer packages to resolve any breaking changes

I found it difficult to review changes to
`@metamask/profile-sync-controller` as it was not completely clear to me
what this package exported.

For other packages we have begun using unit tests for `index.ts` files
to make exports more visible. This commit adds such tests.
@mcmire mcmire requested review from a team as code owners December 3, 2024 00:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant