Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(address-book-controller): Rename ControllerMessenger to Messenger #5091

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

Gudahtt
Copy link
Member

@Gudahtt Gudahtt commented Dec 20, 2024

Explanation

Rename ControllerMessenger to Messenger in the @metamask/address-book-controller package.

References

Relates to #4538

Changelog

No functional changes.

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
  • I've highlighted breaking changes using the "BREAKING" category above as appropriate
  • I've prepared draft pull requests for clients and consumer packages to resolve any breaking changes

@Gudahtt Gudahtt force-pushed the messenger-rename-address-book-controller branch from 8ede01c to 5ab594d Compare December 20, 2024 06:32
@Gudahtt Gudahtt marked this pull request as ready for review December 20, 2024 06:40
@Gudahtt Gudahtt requested review from a team as code owners December 20, 2024 06:40
cryptodev-2s
cryptodev-2s previously approved these changes Dec 20, 2024
Copy link
Contributor

@cryptodev-2s cryptodev-2s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Contributor

@cryptodev-2s cryptodev-2s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

…enger`

Rename `ControllerMessenger` to `Messenger` in the
`@metamask/address-book-controller` package. The `AddressBookControllerMessenger`
type export was renamed to `AddressBookMessenger`, but the old name is
preserved as an alias.

Relates to #4538
This reverts the sole functional change in this PR.
@Gudahtt Gudahtt force-pushed the messenger-rename-address-book-controller branch from 2319c75 to 859b348 Compare January 10, 2025 00:21
@Gudahtt Gudahtt enabled auto-merge (squash) January 10, 2025 00:22
Copy link
Contributor

@mcmire mcmire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants