Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: verify core PR 5078 #29316

Closed
wants to merge 4 commits into from
+12 −7
Closed

test: verify core PR 5078 #29316

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
59e167b
test: verify core PR 5078
mathieuartu Dec 18, 2024
e54c67a
fix: lint
mathieuartu Dec 18, 2024
a5a7b65
fix: sentry state
mathieuartu Dec 18, 2024
3d2e5c4
fix: e2e state
mathieuartu Dec 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions app/scripts/constants/sentry-state.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -401,6 +401,7 @@ export const SENTRY_BACKGROUND_STATE = {
isProfileSyncingUpdateLoading: false,
hasAccountSyncingSyncedAtLeastOnce: false,
isAccountSyncingReadyToBeDispatched: false,
isAccountSyncingInProgress: false,
},
///: BEGIN:ONLY_INCLUDE_IF(build-mmi)
...MMI_SENTRY_BACKGROUND_STATE,
Expand Down
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -332,7 +332,7 @@
"@metamask/post-message-stream": "^8.0.0",
"@metamask/ppom-validator": "0.36.0",
"@metamask/preinstalled-example-snap": "^0.2.0",
"@metamask/profile-sync-controller": "^3.1.1",
"@metamask/profile-sync-controller": "npm:@metamask-previews/profile-sync-controller@3.1.1-preview-e218ba33",
"@metamask/providers": "^18.2.0",
"@metamask/queued-request-controller": "^7.0.1",
"@metamask/rate-limit-controller": "^6.0.0",
Expand Down
3 changes: 2 additions & 1 deletion test/e2e/tests/metrics/state-snapshots/errors-after-init-opt-in-background-state.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -355,6 +355,7 @@
"isProfileSyncingEnabled": null,
"isProfileSyncingUpdateLoading": "boolean",
"hasAccountSyncingSyncedAtLeastOnce": "boolean",
"isAccountSyncingReadyToBeDispatched": "boolean"
"isAccountSyncingReadyToBeDispatched": "boolean",
"isAccountSyncingInProgress": "boolean"
}
}
1 change: 1 addition & 0 deletions test/e2e/tests/metrics/state-snapshots/errors-after-init-opt-in-ui-state.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -223,6 +223,7 @@
"isProfileSyncingUpdateLoading": "boolean",
"hasAccountSyncingSyncedAtLeastOnce": "boolean",
"isAccountSyncingReadyToBeDispatched": "boolean",
"isAccountSyncingInProgress": "boolean",
"subscriptionAccountsSeen": "object",
"isMetamaskNotificationsFeatureSeen": "boolean",
"isNotificationServicesEnabled": "boolean",
Expand Down
1 change: 1 addition & 0 deletions test/integration/notifications&auth/data/notification-state.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,7 @@ export const getMockedNotificationsState = () => {
isProfileSyncingEnabled: true,
isProfileSyncingUpdateLoading: false,
hasAccountSyncingSyncedAtLeastOnce: false,
isAccountSyncingInProgress: false,
isAccountSyncingReadyToBeDispatched: false,
isMetamaskNotificationsFeatureSeen: true,
isNotificationServicesEnabled: true,
Expand Down
1 change: 1 addition & 0 deletions ui/selectors/identity/profile-syncing.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ describe('Profile Syncing Selectors', () => {
isProfileSyncingUpdateLoading: false,
isAccountSyncingReadyToBeDispatched: false,
hasAccountSyncingSyncedAtLeastOnce: false,
isAccountSyncingInProgress: false,
},
};

Expand Down
10 changes: 5 additions & 5 deletions yarn.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6046,9 +6046,9 @@ __metadata:
languageName: node
linkType: hard

"@metamask/profile-sync-controller@npm:^3.1.1":
version: 3.1.1
resolution: "@metamask/profile-sync-controller@npm:3.1.1"
"@metamask/profile-sync-controller@npm:@metamask-previews/profile-sync-controller@3.1.1-preview-e218ba33":
version: 3.1.1-preview-e218ba33
resolution: "@metamask-previews/profile-sync-controller@npm:3.1.1-preview-e218ba33"
dependencies:
"@metamask/base-controller": "npm:^7.0.2"
"@metamask/keyring-api": "npm:^12.0.0"
Expand All @@ -6068,7 +6068,7 @@ __metadata:
"@metamask/providers": ^18.1.0
"@metamask/snaps-controllers": ^9.10.0
webextension-polyfill: ^0.10.0 || ^0.11.0 || ^0.12.0
checksum: 10/42dd1ea0f9595eca6bd1a179681f7d16dfc6cc5090494131c8999a15caa02866f133febe1a95fca7cc74b4f3dafa7ef740f27b08eadbbf3049ebc087a739fb1b
checksum: 10/b58a997a48d56afb41d275b98de08d91d7fa485f27af306ae1ad0593dc8b8c23eb83f8552acb9a849a9363f49fc814b5c0932065f60e1c8f91e5e1b7b2616bc1
languageName: node
linkType: hard

Expand Down Expand Up @@ -26608,7 +26608,7 @@ __metadata:
"@metamask/ppom-validator": "npm:0.36.0"
"@metamask/preferences-controller": "npm:^15.0.1"
"@metamask/preinstalled-example-snap": "npm:^0.2.0"
"@metamask/profile-sync-controller": "npm:^3.1.1"
"@metamask/profile-sync-controller": "npm:@metamask-previews/profile-sync-controller@3.1.1-preview-e218ba33"
"@metamask/providers": "npm:^18.2.0"
"@metamask/queued-request-controller": "npm:^7.0.1"
"@metamask/rate-limit-controller": "npm:^6.0.0"
Expand Down
Loading