Skip to content

fix: improve assets perfs #40978

fix: improve assets perfs

fix: improve assets perfs #40978

Triggered via pull request January 15, 2025 18:09
Status Failure
Total duration 9m 18s
Artifacts 8

ci.yml

on: pull_request
Matrix: unit-tests
js-bundle-size-check
7m 5s
js-bundle-size-check
Matrix: scripts
git-safe-dependencies
2m 9s
git-safe-dependencies
merge-unit-tests
0s
merge-unit-tests
ship-js-bundle-size-check
0s
ship-js-bundle-size-check
sonar-cloud
0s
sonar-cloud
sonar-cloud-quality-gate-status
0s
sonar-cloud-quality-gate-status
All jobs pass
0s
All jobs pass
Check all jobs pass
0s
Check all jobs pass
Fit to window
Zoom out
Zoom in

Annotations

16 errors and 11 warnings
scripts (lint): app/components/UI/Tokens/TokenList/PortfolioBalance/index.tsx#L128
React Hook useMemo has an unnecessary dependency: 'isPortfolioViewEnabled'. Either exclude it or remove the dependency array. Outer scope values like 'isPortfolioViewEnabled' aren't valid dependencies because mutating them doesn't re-render the component
scripts (lint): app/components/UI/Tokens/TokenList/index.tsx#L4
'useNavigation' is defined but never used
scripts (lint): app/components/UI/Tokens/TokenList/index.tsx#L5
'StackNavigationProp' is defined but never used
scripts (lint): app/components/UI/Tokens/TokenList/index.tsx#L8
'useMetrics' is defined but never used
scripts (lint): app/components/UI/Tokens/TokenList/index.tsx#L9
'MetaMetricsEvents' is defined but never used
scripts (lint): app/components/UI/Tokens/TokenList/index.tsx#L12
'createDetectedTokensNavDetails' is defined but never used
scripts (lint): app/components/UI/Tokens/TokenList/index.tsx#L13
'selectChainId' is defined but never used
scripts (lint): app/components/UI/Tokens/TokenList/index.tsx#L14
'selectDetectedTokens' is defined but never used
scripts (lint): app/components/UI/Tokens/TokenList/index.tsx#L16
'getDecimalChainId' is defined but never used
scripts (lint): app/components/UI/Tokens/index.tsx#L60
'throttle' is defined but never used
unit-tests (8)
Process completed with exit code 1.
unit-tests (3)
The job was canceled because "_8" failed.
unit-tests (3)
The operation was canceled.
unit-tests (9)
The job was canceled because "_8" failed.
unit-tests (9)
The operation was canceled.
Check all jobs pass
Process completed with exit code 1.
Check workflows
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636
scripts (lint): app/components/Views/confirmations/components/UI/BottomModal/BottomModal.tsx#L9
'#414141' Hex color values are not allowed. Consider using design tokens instead. For support reach out to the design system team #metamask-design-system on Slack
scripts (lint): app/core/Engine/Engine.ts#L1881
Unexpected labeled statement
scripts (lint): app/core/Engine/Engine.ts#L1886
Unexpected label in break statement
scripts (lint): app/core/NotificationsManager.test.ts#L129
Trailing spaces not allowed
scripts (lint): app/core/NotificationsManager.test.ts#L175
Trailing spaces not allowed
scripts (lint): app/core/NotificationsManager.test.ts#L200
Trailing spaces not allowed
scripts (lint): app/core/NotificationsManager.test.ts#L207
Trailing spaces not allowed
scripts (lint): app/core/NotificationsManager.test.ts#L220
Trailing spaces not allowed
scripts (lint): app/core/NotificationsManager.test.ts#L233
Trailing spaces not allowed

Artifacts

Produced during runtime
Name Size
coverage-1
1010 KB
coverage-10
1010 KB
coverage-2
982 KB
coverage-4
1010 KB
coverage-5
1.01 MB
coverage-6
1010 KB
coverage-7
1020 KB
ios-bundle
8.35 MB