Skip to content

Commit

Permalink
feat: add stablecoin lending feature flag (#12911)
Browse files Browse the repository at this point in the history
## **Description**

This PR add a new feature flag for stable coin lending UI .

## **Related issues**

Fixes:
[STAKE-893](https://consensyssoftware.atlassian.net/browse/STAKE-893)

## **Manual testing steps**

1. Go to this page...
2.
3.

## **Screenshots/Recordings**

<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->

### **Before**

<!-- [screenshots/recordings] -->

### **After**

<!-- [screenshots/recordings] -->

## **Pre-merge author checklist**

- [x] I’ve followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile
Coding
Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [x] I've completed the PR template to the best of my ability
- [x] I’ve included tests if applicable
- [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [x] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.


[STAKE-893]:
https://consensyssoftware.atlassian.net/browse/STAKE-893?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ
  • Loading branch information
amitabh94 authored Jan 10, 2025
1 parent 596c252 commit b2fe978
Show file tree
Hide file tree
Showing 3 changed files with 20 additions and 11 deletions.
7 changes: 5 additions & 2 deletions .js.env.example
Original file line number Diff line number Diff line change
@@ -1,10 +1,10 @@
# Sign up and generate your own keys at pubnub.com
# Then rename this file to ".js.env" and rebuild the app
#
#
# In order for this feature to work properly, you need to
# build metamask-extension from source (https://github.com/MetaMask/metamask-extension)
# and set your the same values there.
#
#
# For more info take a look at https://github.com/MetaMask/metamask-extension/pull/5955

export MM_PUBNUB_SUB_KEY=""
Expand Down Expand Up @@ -107,3 +107,6 @@ export MM_MULTICHAIN_V1_ENABLED=""

# Permissions Settings feature flag specific to UI changes
export MM_PERMISSIONS_SETTINGS_V1_ENABLED=""

# Feature flag for Stablecoin Lending UI
export MM_STABLECOIN_LENDING_UI_ENABLED="true"
3 changes: 3 additions & 0 deletions app/components/UI/Stake/constants/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -2,5 +2,8 @@
export const isPooledStakingFeatureEnabled = () =>
process.env.MM_POOLED_STAKING_UI_ENABLED === 'true';

export const isStablecoinLendingFeatureEnabled = () =>
process.env.MM_STABLECOIN_LENDING_UI_ENABLED === 'true';

export const POOLED_STAKING_FAQ_URL =
'https://support.metamask.io/metamask-portfolio/move-crypto/stake/staking-pool/';
21 changes: 12 additions & 9 deletions bitrise.yml
Original file line number Diff line number Diff line change
Expand Up @@ -114,7 +114,7 @@ stages:
workflows:
- deploy_android_to_store: {}
create_build_qa_and_expo:
workflows:
workflows:
- build_android_devbuild: {}
- build_android_qa: {}
- build_ios_devbuild: {}
Expand Down Expand Up @@ -1247,20 +1247,20 @@ workflows:
- content: |-
# Define the source path of the generated APK
SOURCE_APK_PATH="$PROJECT_LOCATION/app/build/outputs/apk/prod/debug/app-prod-debug.apk"
# Define the destination path with the new name
DEST_APK_PATH="$BITRISE_DEPLOY_DIR/android-expo-dev-build.apk"
# Copy and rename the APK
cp "$SOURCE_APK_PATH" "$DEST_APK_PATH"
# Optionally, print the new path for verification
echo "APK has been copied and renamed to: $DEST_APK_PATH"
- [email protected]:
is_always_run: false
is_skippable: true
inputs:
- deploy_path: "$BITRISE_DEPLOY_DIR/android-expo-dev-build.apk"
- deploy_path: '$BITRISE_DEPLOY_DIR/android-expo-dev-build.apk'
title: Bitrise Deploy APK
meta:
bitrise.io:
Expand Down Expand Up @@ -1537,21 +1537,21 @@ workflows:
- content: |-
# Define the source path of the generated IPA
SOURCE_IPA_PATH="ios/build/output/MetaMask.ipa"
# Define the destination path with the new name
DEST_IPA_PATH="$BITRISE_DEPLOY_DIR/ios-expo-dev-build.ipa"
# Copy and rename the IPA
cp "$SOURCE_IPA_PATH" "$DEST_IPA_PATH"
# Optionally, print the new path for verification
echo "IPA has been copied and renamed to: $DEST_IPA_PATH"
- [email protected]:
is_always_run: false
is_skippable: true
inputs:
- pipeline_intermediate_files: ios/build/output/MetaMask.ipa:BITRISE_APP_STORE_IPA_PATH
- deploy_path: "$BITRISE_DEPLOY_DIR/ios-expo-dev-build.ipa"
- deploy_path: '$BITRISE_DEPLOY_DIR/ios-expo-dev-build.ipa'
title: Deploy iOS IPA
build_ios_qa:
envs:
Expand Down Expand Up @@ -1761,6 +1761,9 @@ app:
- opts:
is_expand: false
MM_SECURITY_ALERTS_API_ENABLED: true
- opts:
is_expand: false
MM_STABLECOIN_LENDING_UI_ENABLED: false
- opts:
is_expand: false
PROJECT_LOCATION: android
Expand Down

0 comments on commit b2fe978

Please sign in to comment.