Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug]: In the Blockaid message, the "Report an issue" link is not fully visible on the screen #12953

Open
sleepytanya opened this issue Jan 11, 2025 · 1 comment
Open

[Bug]: In the Blockaid message, the "Report an issue" link is not fully visible on the screen #12953

sleepytanya opened this issue Jan 11, 2025 · 1 comment
Assignees
@jpuri
Labels
regression-RC-7.38.0 Regression bug that was found in release candidate (RC) for release 7.38.0 Sev3-low A possible confusion or deception that is only hypothetical & has no known instances in the wild team-confirmations Push issues to confirmations team type-bug Something isn't working

Comments

@sleepytanya
Copy link
Contributor

Describe the bug

In the Blockaid message, the "Report an issue" link is not fully visible on the screen

Expected behavior

The message should be fully visible.

Screenshots/Recordings

Image

Steps to reproduce

  1. Trigger malicious transaction
  2. Click 'See details' in the Blockaid warning
  3. 'Report an issue' link is not fully visible

Error messages or log output



Detection stage


During release testing


Version


7.38.0(1523)


Build type


None


Device


iPhone 15


Operating system


iOS


Additional context


No response


Severity


No response

      		
    

      
  





        



            

              
            

        

      


      
    








      

    



      

  
            

    

      
    

    


      

          @sleepytanya
sleepytanya




            added
      

  regression-RC-7.38.0

  Regression bug that was found in release candidate (RC) for release 7.38.0

      

  Sev3-low

  A possible confusion or deception that is only hypothetical & has no known instances in the wild

      

  team-confirmations

  Push issues to confirmations team

      

  type-bug

  Something isn't working

  labels


      Jan 11, 2025

    

  



    


    

    

      
    

    


      

          @github-project-automation
github-project-automation
bot



          moved this to To be fixed
  in Bugs by severity


      Jan 11, 2025

    

  



    

    

      
    

    


      

          @github-project-automation
github-project-automation
bot



          moved this to To be fixed
  in Bugs by team


      Jan 11, 2025

    

  



    







      

  
      



  

  @jpuri





  


    

      

  

    

        
    
    

  


      
          
  
      
            Copy link

  

      
    

  


  

      

  
    Contributor


      

  


  

    

      

      
            jpuri
  

      

      

      commented


        Jan 14, 2025


      
    


  





      


        


  
    

      
          
The PR will fix this issue: #12954

      		
    

  





        


            

            

              
            

        

      


      

            
  

    
  
    
    

  

  



    












      

  
          

  

    
  


  

      

    @jpuri
jpuri



    mentioned this issue
    
      Jan 14, 2025
    





  


  

      
   Merged

  





  
  

      
        
      
      

  
    
    
  


    7 tasks
  





  




  


  
    
  
  

    
  github-merge-queue bot

      pushed a commit
      that referenced
      this issue

    
      Jan 14, 2025
    
    

      


  

    

      


  

      
        @jpuri
  





      

        
          fix: Addressing UX feedbacks on re-designed signature pages (#12954)
        

          
            
          

      


      

          

    
    
    

  

    


      


      

          

    
    
    

  

  

    
  



      


      
      

        
          7c35015
        
      

    

  

    

      
## **Description**

Addressing UX feedbacks on re-designed signature pages.

## **Related issues**

Fixes: MetaMask/MetaMask-planning#3878,
MetaMask/MetaMask-planning#3880,
MetaMask/MetaMask-planning#3881,
MetaMask/MetaMask-planning#3883,
MetaMask/MetaMask-planning#3882,
#12953

## **Manual testing steps**

1. Enable re-designs locally
2. Open signature pages in test dapp
3. Check UX of different signature pages

## **Screenshots/Recordings**
<img width="385" alt="Screenshot 2025-01-13 at 11 41 10 AM"
src="https://github.com/user-attachments/assets/309bb65a-75d4-456d-bf06-6852a0759e11"
/>
<img width="381" alt="Screenshot 2025-01-13 at 11 33 18 AM"
src="https://github.com/user-attachments/assets/ebb19284-a54e-4597-8877-3ec4daa7288f"
/>

## **Pre-merge author checklist**

- [X] I’ve followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile
Coding
Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [X] I've completed the PR template to the best of my ability
- [X] I’ve included tests if applicable
- [X] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [X] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.

    




    

  













  
  

    

      

  





  




  
  

              

  
    Sign up for free
    to join this conversation on GitHub.
    Already have an account?
    Sign in to comment


  



  






  
                  




    

  


      
  

    Assignees
  



        

      

        

  
      @jpuri
  
    jpuri
    

      








      


  


  

    Labels
  



    

      

    regression-RC-7.38.0

  Regression bug that was found in release candidate (RC) for release 7.38.0
  

    Sev3-low

  A possible confusion or deception that is only hypothetical & has no known instances in the wild
  

    team-confirmations

  Push issues to confirmations team
  

    type-bug

  Something isn't working








      

  

    

        

    Projects
  


        




        
  

    

      
          
        Bugs by severity
        
    

    

      

            
    Status: To be fixed

              
      

    

    

  



        
  

    

      
          
        Bugs by team
        
    

    

      

            
    Status: To be fixed

              
      

    

    

  







  



      


  

    
  

    Milestone
  


      No milestone





    
      
          


  

    
      

        
    

    Development
  




          
    
No branches or pull requests







    
  




      

    

  
      

  

    

      2 participants
    

    

        
          @jpuri 
        
          @sleepytanya