Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Addressing UX feedbacks on re-designed signature pages #12954

Merged
merged 18 commits into from
Jan 14, 2025
Merged

Conversation

jpuri
Copy link
Contributor

@jpuri jpuri commented Jan 13, 2025

Description

Addressing UX feedbacks on re-designed signature pages.

Related issues

Fixes: https://github.com/MetaMask/MetaMask-planning/issues/3878, https://github.com/MetaMask/MetaMask-planning/issues/3880, https://github.com/MetaMask/MetaMask-planning/issues/3881, https://github.com/MetaMask/MetaMask-planning/issues/3883, https://github.com/MetaMask/MetaMask-planning/issues/3882,
#12953

Manual testing steps

  1. Enable re-designs locally
  2. Open signature pages in test dapp
  3. Check UX of different signature pages

Screenshots/Recordings

Screenshot 2025-01-13 at 11 41 10 AM Screenshot 2025-01-13 at 11 33 18 AM

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Sorry, something went wrong.

jpuri added 7 commits January 10, 2025 18:33

Verified

This commit was signed with the committer’s verified signature.
Rjvs Robert J Spencer
@jpuri jpuri added the team-confirmations Push issues to confirmations team label Jan 13, 2025
@jpuri jpuri requested a review from a team as a code owner January 13, 2025 06:19
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

jpuri added 7 commits January 13, 2025 12:00
@jpuri jpuri requested a review from a team as a code owner January 13, 2025 15:15
jpuri added 2 commits January 13, 2025 20:59
Base automatically changed from sig_metrics to main January 14, 2025 05:19
@jpuri jpuri added the Run Smoke E2E Triggers smoke e2e on Bitrise label Jan 14, 2025
Copy link
Contributor

github-actions bot commented Jan 14, 2025

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 9c89033
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/06f32b52-ac63-451d-9d4f-ad0247d958e1

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@jpuri jpuri added this pull request to the merge queue Jan 14, 2025
Merged via the queue into main with commit 7c35015 Jan 14, 2025
40 of 41 checks passed
@jpuri jpuri deleted the ux_fixes branch January 14, 2025 19:50
@github-actions github-actions bot locked and limited conversation to collaborators Jan 14, 2025
@metamaskbot metamaskbot added the release-7.39.0 Issue or pull request that will be included in release 7.39.0 label Jan 14, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-7.39.0 Issue or pull request that will be included in release 7.39.0 Run Smoke E2E Triggers smoke e2e on Bitrise team-confirmations Push issues to confirmations team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants