Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Adding blockaid banner to re-designed confirmation pages #12863

Merged
merged 1 commit into from
Jan 10, 2025

Conversation

jpuri
Copy link
Contributor

@jpuri jpuri commented Jan 8, 2025

Description

Add blockaid banner to re-designed signature request pages.

Related issues

Fixes: https://github.com/MetaMask/MetaMask-planning/issues/3741

Manual testing steps

  1. Enable re-designs confirmations locally on mobile
  2. Submit malicious signature request
  3. Ensure that blockaid banner is present on the page

Screenshots/Recordings

Screenshot 2025-01-08 at 4 36 09 PM

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@jpuri jpuri requested a review from a team as a code owner January 8, 2025 12:07
Copy link
Contributor

github-actions bot commented Jan 8, 2025

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added the team-confirmations Push issues to confirmations team label Jan 8, 2025
@jpuri jpuri requested a review from a team as a code owner January 8, 2025 12:15
Base automatically changed from typed_v3v4_data_tree to main January 9, 2025 14:13
@jpuri jpuri added the Run Smoke E2E Triggers smoke e2e on Bitrise label Jan 9, 2025
Copy link
Contributor

github-actions bot commented Jan 9, 2025

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 552d138
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/e951c1fa-b3e4-45bc-a2c9-c014d3aff862

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

Copy link

sonarqubecloud bot commented Jan 9, 2025

@jpuri jpuri added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Jan 10, 2025
@jpuri jpuri added this pull request to the merge queue Jan 10, 2025
Merged via the queue into main with commit 596c252 Jan 10, 2025
41 of 43 checks passed
@jpuri jpuri deleted the blockaid_banner branch January 10, 2025 10:01
@github-actions github-actions bot locked and limited conversation to collaborators Jan 10, 2025
@metamaskbot metamaskbot added the release-7.39.0 Issue or pull request that will be included in release 7.39.0 label Jan 10, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-7.39.0 Issue or pull request that will be included in release 7.39.0 Run Smoke E2E Triggers smoke e2e on Bitrise team-confirmations Push issues to confirmations team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants