Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add transactionMeta condition to render SimulationDetails #12916

Merged
merged 4 commits into from
Jan 10, 2025

Conversation

OGPoyraz
Copy link
Member

@OGPoyraz OGPoyraz commented Jan 9, 2025

Description

This PR aims to remove render case for SimulationDetails when transactionMeta is not ready.

Related issues

Fixes: #12914

Manual testing steps

  1. Open the app and initiate a transaction.
  2. Enter a destination wallet address in the send view.
  3. Navigate to the confirmation screen.
  4. Return to the send view and edit the destination wallet address.
  5. Navigate back to the confirmation screen.

Screenshots/Recordings

Simulator.Screen.Recording.-.iPhone.13.Pro.-.2025-01-09.at.18.15.42.mp4

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@OGPoyraz OGPoyraz requested a review from a team as a code owner January 9, 2025 17:19
@metamaskbot metamaskbot added the team-confirmations Push issues to confirmations team label Jan 9, 2025
@OGPoyraz OGPoyraz added No QA Needed Apply this label when your PR does not need any QA effort. Run Smoke E2E Triggers smoke e2e on Bitrise labels Jan 9, 2025
Copy link
Contributor

github-actions bot commented Jan 9, 2025

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 2ffb812
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/c34760ed-9a38-4d70-9dc7-d433b3e47a80

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@OGPoyraz OGPoyraz added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Jan 9, 2025
@Andepande Andepande added QA Passed A successful QA run through has been done and removed No QA Needed Apply this label when your PR does not need any QA effort. labels Jan 9, 2025
Copy link
Member

@Andepande Andepande left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG QA Passed

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.72%. Comparing base (9d6908b) to head (7b4102f).
Report is 54 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #12916      +/-   ##
==========================================
+ Coverage   58.85%   59.72%   +0.87%     
==========================================
  Files        1851     1863      +12     
  Lines       41739    41996     +257     
  Branches     5397     5456      +59     
==========================================
+ Hits        24566    25083     +517     
+ Misses      15502    15235     -267     
- Partials     1671     1678       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@OGPoyraz OGPoyraz added this pull request to the merge queue Jan 10, 2025
Merged via the queue into main with commit e726417 Jan 10, 2025
37 checks passed
@OGPoyraz OGPoyraz deleted the fix/transaction-simulation-bug branch January 10, 2025 06:51
@github-actions github-actions bot locked and limited conversation to collaborators Jan 10, 2025
@metamaskbot metamaskbot added the release-7.39.0 Issue or pull request that will be included in release 7.39.0 label Jan 10, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
QA Passed A successful QA run through has been done release-7.39.0 Issue or pull request that will be included in release 7.39.0 Run Smoke E2E Triggers smoke e2e on Bitrise team-confirmations Push issues to confirmations team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Error: "Cannot read property 'chainId' of undefined" after editing destination wallet address
5 participants