Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Adding metrics events for re-designed signatures pages #12927

Merged
merged 12 commits into from
Jan 14, 2025
Merged

Conversation

jpuri
Copy link
Contributor

@jpuri jpuri commented Jan 10, 2025

Description

Capture signature events in metrics in re-designed signature pages:

  1. Signature requested
  2. Signature approved
  3. Signature rejected

Also capture ui_customizations with the value redesigned_confirmation for re-designed pages.

Related issues

Fixes: https://github.com/MetaMask/MetaMask-planning/issues/3856, https://github.com/MetaMask/MetaMask-planning/issues/3867

Manual testing steps

  1. Enable re-designs and metrics locally
  2. Submit signature request
  3. Check metrics

Screenshots/Recordings

NA

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@jpuri jpuri added the team-confirmations Push issues to confirmations team label Jan 10, 2025
@jpuri jpuri requested a review from a team as a code owner January 10, 2025 13:07
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@jpuri jpuri added the Run Smoke E2E Triggers smoke e2e on Bitrise label Jan 10, 2025
Copy link
Contributor

github-actions bot commented Jan 10, 2025

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: c334156
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/d613c9f0-9729-4ab7-b404-5cd3995239b6

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

@jpuri jpuri requested a review from matthewwalsh0 January 13, 2025 06:33
@jpuri jpuri requested a review from a team as a code owner January 13, 2025 14:52
@jpuri jpuri added this pull request to the merge queue Jan 14, 2025
Merged via the queue into main with commit bdbb3e0 Jan 14, 2025
36 of 37 checks passed
@jpuri jpuri deleted the sig_metrics branch January 14, 2025 05:19
@github-actions github-actions bot locked and limited conversation to collaborators Jan 14, 2025
@metamaskbot metamaskbot added the release-7.39.0 Issue or pull request that will be included in release 7.39.0 label Jan 14, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-7.39.0 Issue or pull request that will be included in release 7.39.0 Run Smoke E2E Triggers smoke e2e on Bitrise team-confirmations Push issues to confirmations team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants