Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Keep latest 50 history instead of first 50 #12929

Merged
merged 2 commits into from
Jan 10, 2025
Merged

Conversation

ziad-saab
Copy link
Contributor

Description

History is kept in chronological order, but we cut off the latest elements instead of the most recent ones. This PR fixes that.

Manual testing steps

  1. Make sure you have 50 elements in your history
  2. Browse to a URL you've never been to before
  3. Verify that the new URL is part of your browsing history

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

History is kept in chronological order, but we cut off the latest elements instead of the most recent ones. This commit fixes that
@ziad-saab ziad-saab added team-portfolio No E2E Smoke Needed If the PR does not need E2E smoke test run labels Jan 10, 2025
@ziad-saab ziad-saab requested a review from a team as a code owner January 10, 2025 16:19
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added the INVALID-PR-TEMPLATE PR's body doesn't match template label Jan 10, 2025
@ziad-saab ziad-saab added No QA Needed Apply this label when your PR does not need any QA effort. and removed INVALID-PR-TEMPLATE PR's body doesn't match template labels Jan 10, 2025
Copy link
Contributor

@sethkfman sethkfman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ziad-saab ziad-saab added this pull request to the merge queue Jan 10, 2025
Merged via the queue into main with commit 28031f6 Jan 10, 2025
39 of 41 checks passed
@ziad-saab ziad-saab deleted the zs/keep-latest-history branch January 10, 2025 17:20
@github-actions github-actions bot locked and limited conversation to collaborators Jan 10, 2025
@metamaskbot metamaskbot added the release-7.39.0 Issue or pull request that will be included in release 7.39.0 label Jan 10, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
No E2E Smoke Needed If the PR does not need E2E smoke test run No QA Needed Apply this label when your PR does not need any QA effort. release-7.39.0 Issue or pull request that will be included in release 7.39.0 team-portfolio
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants