Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Addressing design feedbacks on re-designed signature pages #12957

Merged
merged 25 commits into from
Jan 15, 2025

Conversation

jpuri
Copy link
Contributor

@jpuri jpuri commented Jan 13, 2025

Description

Addressing design feedbacks details here on re-designed signature request pages.

Related issues

Fixes: https://github.com/MetaMask/MetaMask-planning/issues/3900

Manual testing steps

  1. Enable re-designs locally
  2. Open test-dapp and submit signature requests
  3. Check re-designed signature request pages

Screenshots/Recordings

todo

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added the team-confirmations Push issues to confirmations team label Jan 13, 2025
@jpuri jpuri changed the base branch from ux_fixes to main January 14, 2025 11:57
@jpuri jpuri changed the base branch from main to ux_fixes January 14, 2025 11:58
Base automatically changed from ux_fixes to main January 14, 2025 19:50
@jpuri jpuri marked this pull request as ready for review January 15, 2025 03:11
@jpuri jpuri requested review from a team as code owners January 15, 2025 03:11
@jpuri jpuri changed the title Addressing design feedbacks on re-designed signature pages fix: Addressing design feedbacks on re-designed signature pages Jan 15, 2025
@jpuri jpuri added the Run Smoke E2E Triggers smoke e2e on Bitrise label Jan 15, 2025
Copy link
Contributor

github-actions bot commented Jan 15, 2025

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 4ed790a
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/e40ba2ca-77af-4588-995d-0246d693c79a

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@jpuri jpuri added this pull request to the merge queue Jan 15, 2025
Merged via the queue into main with commit 0157bb7 Jan 15, 2025
41 of 43 checks passed
@jpuri jpuri deleted the design_feedbacks branch January 15, 2025 05:21
@github-actions github-actions bot locked and limited conversation to collaborators Jan 15, 2025
@metamaskbot metamaskbot added the release-7.39.0 Issue or pull request that will be included in release 7.39.0 label Jan 15, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-7.39.0 Issue or pull request that will be included in release 7.39.0 Run Smoke E2E Triggers smoke e2e on Bitrise team-confirmations Push issues to confirmations team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants