You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Similar to extension, we only want to show the cross chain aggregated balance if the selected network is a popular network, and the "Popular networks" filter is enabled.
If we are on a custom network, we only want to show the aggregated balance for that chain, similar to how we handle testnets.
When a popular network is selected in global network selector and "Popular networks" filter is enabled, show aggregate balance across popular networks. When "Current network" filter is enabled, show aggregated balance for that chain.
When a non-popular network (aka custom network) is selected in global network selector, only show aggregated balance for that chain.
When testnet is selected in global network selector, show aggregated balance for the testnet only. For this case, make sure "Show conversion on test networks" is toggled on.
I've completed the PR template to the best of my ability
I’ve included tests if applicable
I’ve documented my code using JSDoc format if applicable
I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
Pre-merge reviewer checklist
I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
QA PassedA successful QA run through has been donerelease-7.38.0Issue or pull request that will be included in release 7.38.0release-7.39.0Issue or pull request that will be included in release 7.39.0Run Smoke E2ETriggers smoke e2e on Bitriseteam-assets
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
gambinish
added
release-7.38.0
metamaskbot
added
the
release-7.39.0
Description
Similar to extension, we only want to show the cross chain aggregated balance if the selected network is a popular network, and the "Popular networks" filter is enabled.
If we are on a custom network, we only want to show the aggregated balance for that chain, similar to how we handle testnets.
Related issues
Fixes: #12922
Manual testing steps
Screenshots/Recordings
Before
After
Screen.Recording.2025-01-13.at.10.40.57.AM.mov
Pre-merge author checklist
Pre-merge reviewer checklist