Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Adding remote feature flag for signature redesign #12977

Merged
merged 3 commits into from
Jan 14, 2025

Conversation

jpuri
Copy link
Contributor

@jpuri jpuri commented Jan 14, 2025

Description

Adding remote feature flag for signature re-designs.

Related issues

Fixes: https://github.com/MetaMask/MetaMask-planning/issues/3875

Manual testing steps

  1. Run the app locally
  2. Submit signature request and it should open in new designs

Screenshots/Recordings

NA

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@jpuri jpuri added the team-confirmations Push issues to confirmations team label Jan 14, 2025
@jpuri jpuri requested a review from a team as a code owner January 14, 2025 10:57
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@jpuri jpuri enabled auto-merge January 14, 2025 11:03
@jpuri jpuri added the Run Smoke E2E Triggers smoke e2e on Bitrise label Jan 14, 2025
Copy link
Contributor

github-actions bot commented Jan 14, 2025

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 146c063
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/c78c015b-4af6-4f4e-b80b-39d51794c861

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

@jpuri jpuri dismissed stale reviews from matthewwalsh0 and pedronfigueiredo via 3192904 January 14, 2025 11:40
@jpuri jpuri requested a review from a team as a code owner January 14, 2025 11:40
@jpuri jpuri removed the Run Smoke E2E Triggers smoke e2e on Bitrise label Jan 14, 2025
@jpuri jpuri added the Run Smoke E2E Triggers smoke e2e on Bitrise label Jan 14, 2025
Copy link
Contributor

github-actions bot commented Jan 14, 2025

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 5d8f6a9
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/bc410387-22ac-4714-b317-3de64afc374c

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@jpuri jpuri disabled auto-merge January 14, 2025 11:55
@jpuri jpuri added this pull request to the merge queue Jan 14, 2025
Merged via the queue into main with commit 14ed9f1 Jan 14, 2025
38 of 39 checks passed
@jpuri jpuri deleted the redesign_remote_flag branch January 14, 2025 12:46
@github-actions github-actions bot locked and limited conversation to collaborators Jan 14, 2025
@metamaskbot metamaskbot added the release-7.39.0 Issue or pull request that will be included in release 7.39.0 label Jan 14, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-7.39.0 Issue or pull request that will be included in release 7.39.0 Run Smoke E2E Triggers smoke e2e on Bitrise team-confirmations Push issues to confirmations team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants