Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): bump elliptic to ^6.6.0 #12979

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

mikesposito
Copy link
Member

@mikesposito mikesposito commented Jan 14, 2025

Description

This PR bumps elliptic in the dependency tree to mitigate the following security advisories:

The closer version that mitigates all the above advisories is 6.6.0.

Currently on main, these are the versions we have for elliptic:

> yarn why elliptic
=> Found "[email protected]"
info Has been hoisted to "elliptic"
info Reasons this module exists
   - Hoisted from "@walletconnect#utils#elliptic"
   - Hoisted from "@metamask#ppom-validator#elliptic"
   - Hoisted from "secp256k1#elliptic"
   - Hoisted from "ethereumjs-abi#ethereumjs-util#elliptic"
   - Hoisted from "react-native-crypto#create-ecdh#elliptic"
   - Hoisted from "react-native-crypto#browserify-sign#elliptic"
   - Hoisted from "ethereumjs-util#secp256k1#elliptic"
info Disk size without dependencies: "288KB"
info Disk size with unique dependencies: "656KB"
info Disk size with transitive dependencies: "656KB"
info Number of shared dependencies: 7
=> Found "@ethersproject/signing-key#[email protected]"
info This module exists because "ethers#@ethersproject#signing-key" depends on it.
info Disk size without dependencies: "288KB"
info Disk size with unique dependencies: "656KB"
info Disk size with transitive dependencies: "656KB"
info Number of shared dependencies: 7
=> Found "@reown/walletkit#[email protected]"
info Reasons this module exists
   - "@walletconnect#se-sdk#@reown#walletkit#@walletconnect#utils" depends on it
   - Hoisted from "@walletconnect#se-sdk#@reown#walletkit#@walletconnect#utils#elliptic"
info Disk size without dependencies: "172KB"
info Disk size with unique dependencies: "540KB"
info Disk size with transitive dependencies: "540KB"
info Number of shared dependencies: 7
=> Found "@walletconnect/sign-client#[email protected]"
info Reasons this module exists
   - "@walletconnect#se-sdk#@reown#walletkit#@walletconnect#sign-client#@walletconnect#utils" depends on it
   - Hoisted from "@walletconnect#se-sdk#@reown#walletkit#@walletconnect#sign-client#@walletconnect#utils#elliptic"
info Disk size without dependencies: "172KB"
info Disk size with unique dependencies: "540KB"
info Disk size with transitive dependencies: "540KB"
info Number of shared dependencies: 7

The added resolution forces the package on ^6.6.0 which currently resolves to 6.6.1

Related issues

Related: MetaMask/core#4847

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@mikesposito mikesposito requested review from a team as code owners January 14, 2025 13:40
@mikesposito mikesposito requested a review from a team January 14, 2025 13:41
@mikesposito mikesposito added the Run Smoke E2E Triggers smoke e2e on Bitrise label Jan 14, 2025
Copy link
Contributor

github-actions bot commented Jan 14, 2025

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: d7018c0
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/efb9ce5e-aa7d-48f4-93ce-27a3d5486b35

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Run Smoke E2E Triggers smoke e2e on Bitrise team-wallet-framework
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants