Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Remove unused patch #12986

Merged
merged 1 commit into from
Jan 15, 2025
Merged

chore: Remove unused patch #12986

merged 1 commit into from
Jan 15, 2025

Conversation

Gudahtt
Copy link
Member

@Gudahtt Gudahtt commented Jan 14, 2025

Description

The patch for @metamask/controller-utils was not necessary; the changes in the patch were made in v11.4.3, and we're already using v11.4.4.

Changelog: https://github.com/MetaMask/core/blob/main/packages/controller-utils/CHANGELOG.md#1143

This old patch was generating a warning upon running yarn patch-package.

Related issues

N/A

Manual testing steps

  • Run yarn setup, and inspect ./node_modules/@metamask/controller-utils to ensure that the names for Ethereum and Linea are correct
  • Run yarn patch-package, and ensure no warning is shown

Screenshots/Recordings

N/A

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

The patch for `@metamask/controller-utils` was not necessary; the
changes in the patch were made in v11.4.3, and we're already using
v11.4.4.

Changelog: https://github.com/MetaMask/core/blob/main/packages/controller-utils/CHANGELOG.md#1143

This old patch was generating a warning upon running `yarn patch-package`.
@Gudahtt Gudahtt added No QA Needed Apply this label when your PR does not need any QA effort. team-mobile-platform No E2E Smoke Needed If the PR does not need E2E smoke test run labels Jan 14, 2025
@Gudahtt Gudahtt marked this pull request as ready for review January 14, 2025 22:25
@Gudahtt Gudahtt requested a review from a team as a code owner January 14, 2025 22:25
@Gudahtt Gudahtt enabled auto-merge January 14, 2025 22:26
Copy link
Contributor

@sethkfman sethkfman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Gudahtt Gudahtt added this pull request to the merge queue Jan 14, 2025
Merged via the queue into main with commit 224ffbf Jan 15, 2025
54 checks passed
@Gudahtt Gudahtt deleted the remove-unused-patch branch January 15, 2025 00:05
@github-actions github-actions bot locked and limited conversation to collaborators Jan 15, 2025
@metamaskbot metamaskbot added the release-7.39.0 Issue or pull request that will be included in release 7.39.0 label Jan 15, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
No E2E Smoke Needed If the PR does not need E2E smoke test run No QA Needed Apply this label when your PR does not need any QA effort. release-7.39.0 Issue or pull request that will be included in release 7.39.0 team-mobile-platform team-wallet-framework
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants